From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: How to resolve git-am conflict (possible bug)
Date: Sat, 12 Aug 2006 12:49:21 -0700 [thread overview]
Message-ID: <7v7j1dpwe6.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0608121146550.10541@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Sat, 12 Aug 2006 11:52:54 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Sat, 12 Aug 2006, Jakub Narebski wrote:
>
>> Why do we not record commit id in patch?
>
> Because we do not have to.
More relevant point is that more often than not it does not
help. The most common workflow that involves format-patch
output is to give your change to somebody else that does not
have (and does not merge with) your repository, and the commit
that is formatted is your own. The other party does not have
the commit so telling its object name is useless.
Even if you recorded the commit object name of the pre-image
that would not help unless the patch happens to be the first
patch in a series forked from something the other party has.
>> And how git-rebase deals with this?
It applies the format-patch output using "git-am -3". In this
case, the preimage blobs recorded on "index" lines are
guaranteed to exist in the repository the "git-am" runs, because
the patches are coming from the same repository. And the
patches are obviously not munged (we do not give you a chance to
muck with them between the time we generate and we apply) so
they are guaranteed to apply to the blobs recorded on "index"
lines. Running the three-way fallback procedure on a change
already present on the new "onto" branch results in no change in
the index and that is how it notices the patch has already been
applied.
prev parent reply other threads:[~2006-08-12 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 0:30 How to resolve git-am conflict (possible bug) Jakub Narebski
2006-08-12 1:01 ` Junio C Hamano
2006-08-12 1:20 ` Junio C Hamano
2006-08-12 9:10 ` Jakub Narebski
2006-08-12 9:18 ` Jakub Narebski
2006-08-12 19:49 ` Junio C Hamano
2006-08-12 9:52 ` Johannes Schindelin
2006-08-12 19:49 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7j1dpwe6.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).