From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Kalle Valo <Kalle.Valo@iki.fi>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Make .git directory validation code test HEAD
Date: Sat, 27 Aug 2005 21:56:47 -0700 [thread overview]
Message-ID: <7v7je6slps.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0508271334320.3317@g5.osdl.org> (Linus Torvalds's message of "Sat, 27 Aug 2005 13:54:42 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> This also removes the tests for "$GIT_DIR" and "$GIT_OBJECT_DIRECTORY"
> being directories, since the other tests will implicitly test for that
> anyway (ie the tests for HEAD, refs and 00 would fail).
I've thought about it when you brought up the Andrew's naked git
repository detection issue, but one thing I was undecided was
that if we would want to forbid either of these "directories"
being a symlink to another directory. I think it would be OK;
admittedly "test -d" says OK for a symlink to a directory.
I accept the patch, but will not apply and push it out right
now; I am not in a shape to be operating heavy equipment ;-).
Please wait until tomorrow morning.
prev parent reply other threads:[~2005-08-28 4:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-27 14:48 cvsimport error: need a valid pathname Kalle Valo
2005-08-27 15:37 ` Martin Langhoff
2005-08-27 17:44 ` Kalle Valo
2005-08-27 20:54 ` Make .git directory validation code test HEAD Linus Torvalds
2005-08-28 4:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7je6slps.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Kalle.Valo@iki.fi \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).