From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Antoine Pelisse <apelisse@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 2/3] fast-export: improve speed by skipping blobs
Date: Mon, 06 May 2013 10:17:41 -0700 [thread overview]
Message-ID: <7v8v3srpsa.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130506164046.GA20257@sigill.intra.peff.net> (Jeff King's message of "Mon, 6 May 2013 12:40:46 -0400")
Jeff King <peff@peff.net> writes:
> So yes, I think this is an obviously correct optimization. Thanks for
> clarifying, and sorry to be so slow.
No need to be sorry. It just shows that the log message could have
been more helpful.
Here is what I tentatively queued.
commit 83582e91d22c66413b291d4d6d45bbeafddc2af9
Author: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun May 5 17:38:53 2013 -0500
fast-export: do not parse non-commit objects while reading marks file
We read from the marks file and keep only marked commits, but in
order to find the type of object, we are parsing the whole thing,
which is slow, specially in big repositories with lots of big files.
There's no need for that, we can query the object information with
sha1_object_info().
Before this, loading the objects of a fresh emacs import, with 260598
blobs took 14 minutes, after this patch, it takes 3 seconds.
This is the way fast-import does it. Also die if the object is not
found (like fast-import).
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
next prev parent reply other threads:[~2013-05-06 17:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-05 22:38 [PATCH v2 0/3] fast-export: speed improvements Felipe Contreras
2013-05-05 22:38 ` [PATCH v2 1/3] fast-{import,export}: use get_sha1_hex() directly Felipe Contreras
2013-05-07 14:38 ` Junio C Hamano
2013-05-07 22:13 ` Felipe Contreras
2013-05-07 23:19 ` Junio C Hamano
2013-05-05 22:38 ` [PATCH v2 2/3] fast-export: improve speed by skipping blobs Felipe Contreras
2013-05-06 12:31 ` Jeff King
2013-05-06 15:08 ` Junio C Hamano
2013-05-06 16:17 ` Junio C Hamano
2013-05-06 16:20 ` Jeff King
2013-05-06 16:32 ` Junio C Hamano
2013-05-06 16:40 ` Jeff King
2013-05-06 17:17 ` Junio C Hamano [this message]
2013-05-06 17:19 ` Jeff King
2013-05-06 17:41 ` Jeff King
2013-05-06 19:12 ` Felipe Contreras
2013-05-06 19:09 ` Felipe Contreras
2013-05-06 20:58 ` Junio C Hamano
2013-05-06 21:30 ` Felipe Contreras
2013-05-07 1:59 ` Junio C Hamano
2013-05-07 3:49 ` Felipe Contreras
2013-05-06 19:02 ` Felipe Contreras
2013-05-06 19:11 ` Jeff King
2013-05-06 19:15 ` Felipe Contreras
2013-05-05 22:38 ` [PATCH v2 3/3] fast-export: don't parse all the commits Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8v3srpsa.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apelisse@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).