From: Junio C Hamano <gitster@pobox.com>
To: Thomas Ackermann <th.acker@arcor.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Sort howto documents in howto-index.txt
Date: Sat, 22 Dec 2012 11:40:03 -0800 [thread overview]
Message-ID: <7v8v8pri3w.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1870890640.302608.1356201267202.JavaMail.ngmail@webmail13.arcor-online.net> (Thomas Ackermann's message of "Sat, 22 Dec 2012 19:34:27 +0100 (CET)")
Thomas Ackermann <th.acker@arcor.de> writes:
> Howto documents in howto-index.txt were listed in a rather
> random order. So better sort them.
>
> Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> ---
I think $(wildcard) used to sort but in recent GNU make it no longer
does, so this is probably a good change.
Do we need to explicitly sort the api-index as well? $(API_DOCS) is
fed to the script that reads filenames one at a time in the given
order, but I do not see anybody asking for a sorted list while
producing that list. The result looks to be sorted in my build
farm with GNU make 3.82, but that could be by accident.
> Documentation/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index d7417b8..ff8ad9a 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -348,7 +348,7 @@ $(patsubst %.txt,%.texi,$(MAN_TXT)): %.texi : %.xml
>
> howto-index.txt: howto-index.sh $(wildcard howto/*.txt)
> $(QUIET_GEN)$(RM) $@+ $@ && \
> - '$(SHELL_PATH_SQ)' ./howto-index.sh $(wildcard howto/*.txt) >$@+ && \
> + '$(SHELL_PATH_SQ)' ./howto-index.sh $(sort $(wildcard howto/*.txt)) >$@+ && \
> mv $@+ $@
>
> $(patsubst %,%.html,$(ARTICLES)) : %.html : %.txt
next prev parent reply other threads:[~2012-12-22 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 18:34 [PATCH] Sort howto documents in howto-index.txt Thomas Ackermann
2012-12-22 19:40 ` Junio C Hamano [this message]
2012-12-22 19:54 ` Aw: " Thomas Ackermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8v8pri3w.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=th.acker@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).