From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: Failure to extra stable@vger.kernel.org addresses Date: Tue, 20 Nov 2012 15:43:02 -0800 Message-ID: <7v8v9vrgc9.fsf@alter.siamese.dyndns.org> References: <7vlidxuowf.fsf@alter.siamese.dyndns.org> <20121120073100.GB7206@shrek.podlesie.net> <20121120075628.GA7159@shrek.podlesie.net> <20121120115942.GA6132@shrek.podlesie.net> <20121120212126.GA12656@shrek.podlesie.net> <7vhaojrjpx.fsf@alter.siamese.dyndns.org> <20121120230955.GA9686@shrek.podlesie.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Felipe Contreras , Andreas Schwab , Felipe Balbi , git@vger.kernel.org, Tomi Valkeinen To: Krzysztof Mazur X-From: git-owner@vger.kernel.org Wed Nov 21 00:43:23 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TaxTO-0001m1-Ep for gcvg-git-2@plane.gmane.org; Wed, 21 Nov 2012 00:43:22 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354Ab2KTXnH (ORCPT ); Tue, 20 Nov 2012 18:43:07 -0500 Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:62924 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753082Ab2KTXnG (ORCPT ); Tue, 20 Nov 2012 18:43:06 -0500 Received: from smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 23B719B96; Tue, 20 Nov 2012 18:43:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=hJfOVfe+oV7gVtnmeeofpg+xmI4=; b=rVjJVC Cgm/baBwpe4br7+fszLGTbmZLJaDqUiugviE9gtlbE5SEqf+9rp+rymTuf2cpctA qZcMdo5VTUp0BlRxLY1xkuz8gn2R7qfBslZ6V2UrVvpJeFi+XzShpljKUdKiiwxF tT+N3p5NPeywiQ/5F+k+B2XD2phqxJrHWnY+g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=Yo79LroQwamqmMNZH3c9vBNgmkEc0Tyr Hh1sQhTlDWGw2Lrcwi8n7XudYP2Jj20urRD/bH/U+/A5hhkPm0HmpGDkM9Xa2s4B 4cnUMsRTXBXAcgrmlvsk9jLET/j0P11tGQ4lUERd+J++ej44+TzpWzFu8B5BZDBk tW+h9XxEW5E= Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 1070D9B95; Tue, 20 Nov 2012 18:43:05 -0500 (EST) Received: from pobox.com (unknown [98.234.214.94]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 686B89B91; Tue, 20 Nov 2012 18:43:04 -0500 (EST) In-Reply-To: <20121120230955.GA9686@shrek.podlesie.net> (Krzysztof Mazur's message of "Wed, 21 Nov 2012 00:09:55 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 072CA53A-336C-11E2-9B13-C2612E706CDE-77302942!b-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Krzysztof Mazur writes: > On Tue, Nov 20, 2012 at 02:30:02PM -0800, Junio C Hamano wrote: > >> We should probably fix the tools that generate these bogus >> non-addresses first. What's wrong with >> >> Cc: stable kernel (v3.5 v3.6 v3.7) >> >> which should be OK? >> >> Also I suspect that this should be also deemed valid: >> >> Cc: stable@vger.kernel.org (Stable kernel - v3.5 v3.6 v3.7) > > So maybe we should just use the original regex: > > $recipient =~ s/(.*>).*$/$1/ > > which does not add regression for valid addresses, and just fails > in some rare cases when '>' is used in garbage. It was sufficient > for original issue reported by, and tested by Felipe. > > The problem with '>' would be fixed in separate patch. The same > problem exits for invalid address generated by --cc-cmd > (see [PATCH] git-send-email: don't return undefined value in > extract_valid_address()). We would report an error in both cases, > as suggested by Junio. OK, sounds like a plan.