From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v2] tests: add initial bash completion tests
Date: Wed, 11 Apr 2012 16:48:58 -0700 [thread overview]
Message-ID: <7v8vi1j0d1.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1334181423-4391-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Thu, 12 Apr 2012 00:57:03 +0300")
The trailing whitespaces are not visible when reviewing tests, so I'll
squash this in, but otherwise looks good.
Thanks.
t/t9902-completion.sh | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index cbda6b5..51227ac 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -84,30 +84,30 @@ test_expect_success 'basic' '
'
test_expect_success 'double dash' '
- cat >expected <<-\EOF &&
- --paginate
- --no-pager
+ sed -e "s/Z$//" >expected <<-\EOF &&
+ --paginate Z
+ --no-pager Z
--git-dir=
- --bare
- --version
- --exec-path
- --html-path
+ --bare Z
+ --version Z
+ --exec-path Z
+ --html-path Z
--work-tree=
--namespace=
- --help
+ --help Z
EOF
test_completion "git --"
- cat >expected <<-\EOF &&
- --quiet
- --ours
- --theirs
- --track
- --no-track
- --merge
+ sed -e "s/Z$//" >expected <<-\EOF &&
+ --quiet Z
+ --ours Z
+ --theirs Z
+ --track Z
+ --no-track Z
+ --merge Z
--conflict=
- --orphan
- --patch
+ --orphan Z
+ --patch Z
EOF
test_completion "git checkout --"
'
next prev parent reply other threads:[~2012-04-11 23:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 21:57 [PATCH v2] tests: add initial bash completion tests Felipe Contreras
2012-04-11 23:48 ` Junio C Hamano [this message]
2012-04-12 16:15 ` Felipe Contreras
2012-04-12 17:43 ` Junio C Hamano
2012-04-12 23:18 ` Felipe Contreras
2012-04-12 23:26 ` Junio C Hamano
2012-04-13 19:45 ` Junio C Hamano
2012-04-13 9:12 ` SZEDER Gábor
2012-04-13 9:45 ` SZEDER Gábor
2012-04-13 10:48 ` Felipe Contreras
2012-04-13 11:14 ` SZEDER Gábor
2012-04-13 11:56 ` Felipe Contreras
2012-04-13 10:34 ` Felipe Contreras
2012-04-13 10:52 ` SZEDER Gábor
2012-04-13 11:33 ` Thomas Rast
2012-04-13 19:48 ` Junio C Hamano
2012-04-14 2:06 ` Felipe Contreras
2012-04-17 0:31 ` SZEDER Gábor
2012-04-17 6:32 ` Felipe Contreras
2012-04-17 10:22 ` SZEDER Gábor
2012-04-17 10:27 ` [PATCH] tests: add tests for the __gitcomp() completion helper function SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vi1j0d1.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).