From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: Bulgarian translation of git Date: Mon, 13 Feb 2012 00:07:52 -0800 Message-ID: <7v8vk7gnqf.fsf@alter.siamese.dyndns.org> References: <75009f1d7c4aba4d62bb226ab122932c@192.168.122.10> <7vy5s7idxb.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Git List , Christian Stimming , Pat Thoyts , Michele Ballabio , Alex Riesen , Miklos Vajna , Laszlo Papp , Peter Krefting , Christian Couder , Emmanuel Trillaud , Nanako Shiraishi , Mizar , Peter Karlsson , Mikael Magnusson , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= , =?iso-2022-jp?B?QWxleGFuZGVyIFNob3BvdiAoGyRCJyEnXSdWJ1wnYydRJ18bKEI=?= =?iso-2022-jp?B?GyRCJ1UnbCdiGyhCIBskQic6J2AnYSdgJ1MbKEIp?= To: Jiang Xin X-From: git-owner@vger.kernel.org Mon Feb 13 09:08:01 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rwqx7-0008Oh-CK for gcvg-git-2@plane.gmane.org; Mon, 13 Feb 2012 09:08:01 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751555Ab2BMIH4 (ORCPT ); Mon, 13 Feb 2012 03:07:56 -0500 Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:41552 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968Ab2BMIHz (ORCPT ); Mon, 13 Feb 2012 03:07:55 -0500 Received: from smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id A185E5A8B; Mon, 13 Feb 2012 03:07:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=ByIU8ZwNKBMnOIRrX+sxoFTC1Rg=; b=Y3p3Cd zFuZCruKXuI3Xy3JfNopSzrGJvZ9HkBVmE8h/vT1exgWVvtQ6a3EDHJm/6WNX8UG aHPeEJBabXQa6+ycgbmRe8AuyXRgdqS3LVbKK0rli0zf7LkHM7DLptdjGD1521Fm krS6i3ZY1BPXUoK4TvmNQi2/BFj69AkoaeIng= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=owlioeUk5pVER3pCDxqHqHwfxd73SNFV ypDQaM3rQBZOMh0znyCPTgxQ3p2ATiwt9mqclwtiexsXcl1yRwcLBh4FByxWQsDi xVP9uigf5Wws8MTLVMHtSr0waxjjc1iCEZUlXKQn71lqvNBcI2QQspYaZ42Vkest l6H6mffKk4o= Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 96D755A8A; Mon, 13 Feb 2012 03:07:54 -0500 (EST) Received: from pobox.com (unknown [76.102.170.102]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 1D6E45A88; Mon, 13 Feb 2012 03:07:54 -0500 (EST) In-Reply-To: (Jiang Xin's message of "Mon, 13 Feb 2012 15:12:50 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: D4C4C12A-5619-11E1-A56B-9DB42E706CDE-77302942!b-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Jiang Xin writes: >> Somebody needs to eyeball this commit before anything else happens on top >> of it, so that if there is a glaring mistake it can be caught before it >> spreads to affect work by translators for various languages. > > So please check this commit with the updated pot file: > https://github.com/gotgit/git-po/commit/816049b7ec0e5f452c77a4c4e71e2cb40a0ccb45 > Please note In this commit I removed one line from the 'po/.gitignore' file. Thanks. As far as I can tell, this adds git.pot while removes the entry to remove it from po/.gitignore (because now it is a tracked file), but there is no description on how this file was generated in the log message. Please give a short description to the effect that it was mechanically created by running xgettext on the sources as of b6b3b6a (Update draft release notes to 1.7.10, 2012-02-10), or something like that. Other than that, I do not immediately see anything objectionable in this commit; I would still appreciate an extra set of eyeballs or two from people who have worked on gitk and/or git-gui i18n/l10n infrastructure in the past, just in case I forgot to check some obvious/trivial gotchas. I am also Cc'ing people who participated in git-gui and gitk l10n with more than a couple of commits to their po/ part, found by: $ cd git-gui/po && git rev-list --parents HEAD . | while read commit parent do git log --pretty=short $parent..$commit^2 -- :/po done | git shortlog -n -e (same for gitk-git) > As a translater for Chinese, I also made a commit with the translated po file > 'po/zh_CN.po' in branch master-zh-cn (merged back to master branch). Thanks.