From: Junio C Hamano <gitster@pobox.com>
To: kusmabite@gmail.com
Cc: Vincent van Ravesteijn <vfr@lyx.org>,
git@vger.kernel.org, ramsay@ramsay1.demon.co.uk,
msysgit@googlegroups.com
Subject: Re: [PATCHv2] Compile fix for MSVC
Date: Mon, 31 Oct 2011 20:30:42 -0700 [thread overview]
Message-ID: <7v8vo0o6xp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CABPQNSaW+ciEzAMruYVgK_y2xf=sExYiFfdbS4xonKe=h-APjA@mail.gmail.com> (Erik Faye-Lund's message of "Tue, 1 Nov 2011 01:36:27 +0100")
Erik Faye-Lund <kusmabite@gmail.com> writes:
> The result of applying this on top of the current master (1.7.8-rc0)
> compiles and seem to runs fine for me, both with the MinGW supplied by
> msysGit, and MSVC (as outlined by compat/vcbuild/README). Without the
> patches, it fails to build with MSVC. In addition, the changes looks
> good to me. So:
>
> Acked-by: Erik Faye-Lund <kusmabite@gmail.com>
Thanks.
prev parent reply other threads:[~2011-11-01 3:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 19:12 [PATCHv2] Compile fix for MSVC Vincent van Ravesteijn
2011-10-31 19:12 ` [PATCH 1/3] Compile fix for MSVC: Do not include sys/resources.h Vincent van Ravesteijn
2011-10-31 19:12 ` [PATCH 2/3] Compile fix for MSVC: Include <io.h> Vincent van Ravesteijn
2011-10-31 19:12 ` [PATCH 3/3] MSVC: Remove unneeded header stubs Vincent van Ravesteijn
2011-10-31 20:34 ` [PATCHv2] Compile fix for MSVC Junio C Hamano
2011-11-01 0:09 ` [msysGit] " Johannes Schindelin
2011-11-01 3:30 ` Junio C Hamano
2011-11-01 11:56 ` Erik Faye-Lund
2011-11-01 16:45 ` Junio C Hamano
2011-11-01 20:35 ` Erik Faye-Lund
2011-11-01 20:47 ` Junio C Hamano
2011-11-01 18:40 ` Johannes Schindelin
2011-11-01 20:43 ` Erik Faye-Lund
2011-11-01 22:51 ` [msysGit] " Johannes Schindelin
2011-11-01 22:32 ` Vincent van Ravesteijn
2011-11-01 22:40 ` [msysGit] " Johannes Schindelin
2011-11-01 23:33 ` Vincent van Ravesteijn
2011-11-02 0:48 ` [msysGit] " Pat Thoyts
2011-11-02 7:34 ` Vincent van Ravesteijn
2011-11-04 15:39 ` Sebastian Schuberth
2011-11-01 0:36 ` Erik Faye-Lund
2011-11-01 3:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vo0o6xp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=vfr@lyx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).