From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 3/6] revert: fix buffer overflow in insn sheet parser
Date: Wed, 19 Oct 2011 18:30:45 -0700 [thread overview]
Message-ID: <7v8vogbgai.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1319058208-17923-4-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Thu, 20 Oct 2011 02:33:25 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Check that the commit name argument to a "pick" or "revert" action in
> '.git/sequencer/todo' is not too long, to avoid overflowing an
> on-stack buffer. This fixes a regression introduced by 5a5d80f4
> (revert: Introduce --continue to continue the operation, 2011-08-04).
Given that this function is going to be fixed properly so that it does not
even need to use the "on-stack buffer", is this really necessary?
next prev parent reply other threads:[~2011-10-20 1:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 21:03 [PATCH v2 0/6] Sequencer fixups mini-series Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 1/6] revert: free msg in format_todo() Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 2/6] revert: simplify getting commit subject " Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 3/6] revert: fix buffer overflow in insn sheet parser Ramkumar Ramachandra
2011-10-20 1:30 ` Junio C Hamano [this message]
2011-10-20 8:03 ` Jonathan Nieder
2011-10-20 8:48 ` Ramkumar Ramachandra
2011-10-20 9:09 ` Jonathan Nieder
2011-10-20 15:36 ` Ramkumar Ramachandra
2011-10-20 17:15 ` Junio C Hamano
2011-10-20 18:05 ` Jonathan Nieder
2011-10-20 18:55 ` Junio C Hamano
2011-10-22 18:57 ` Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 4/6] revert: make commit subjects in insn sheet optional Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 5/6] revert: allow mixed pick and revert instructions Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 6/6] revert: simplify communicating command-line arguments Ramkumar Ramachandra
-- strict thread matches above, loose matches on Subject: below --
2011-10-08 17:36 [PATCH 0/6] Sequencer fixups mini-series Ramkumar Ramachandra
2011-10-08 17:36 ` [PATCH 3/6] revert: Fix buffer overflow in insn sheet parser Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vogbgai.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).