From: Junio C Hamano <gitster@pobox.com>
To: Kirill Likhodedov <Kirill.Likhodedov@jetbrains.com>
Cc: git@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>
Subject: Re: url.<base>.insteadOf with empty value
Date: Fri, 14 Oct 2011 10:57:42 -0700 [thread overview]
Message-ID: <7v8von1mnd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <54556728-92C0-4992-9831-0D582C383235@jetbrains.com> (Kirill Likhodedov's message of "Fri, 14 Oct 2011 13:03:53 +0400")
Kirill Likhodedov <Kirill.Likhodedov@jetbrains.com> writes:
> If I don't specify any value for url.<base>.insteadOf or url.<base>.pushInsteadOf, Git substitutes all urls for remotes defined in .git/config
>
> Probably that's because any url starts with empty string and thus has to be substituted.
> But it might be a bit confusing, because on the other hand if no value is given to the property insteadOf, user may expect this property to be ignored.
>
> Please check if current Git behavior is correct.
>
> If it is not a bug, I'd suggest to add a note to man git-config about this.
Please assume that what the documentation says is clear enough for whoever
wrote it and need no further clarification, so you would need to help them
understand what additional things you may want the documentation to say,
by clarifying "add a note" and "about this" a bit.
The "insteadOf" replacement is meant to apply for any URL we use. I would
be surprised if it did not affect pushURL; it would be a bug if it didn't.
On the other hand, the rewrite done by "pushinsteadof" is meant to apply
only when remote.<any>.url is used for pushing. See t/t5516-fetch-push.sh
part of the patch for 1c2eafb (Add url.<base>.pushInsteadOf: URL rewriting
for push only, 2009-09-07). It would clarify what the intended interaction
among these configuration variables.
Thanks.
next prev parent reply other threads:[~2011-10-14 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 9:03 url.<base>.insteadOf with empty value Kirill Likhodedov
2011-10-14 17:57 ` Junio C Hamano [this message]
2011-10-14 19:09 ` Kirill Likhodedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8von1mnd.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Kirill.Likhodedov@jetbrains.com \
--cc=git@vger.kernel.org \
--cc=josh@joshtriplett.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).