From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Re* [PATCH 1/2] clone: allow to clone from .git file
Date: Mon, 22 Aug 2011 20:53:01 -0700 [thread overview]
Message-ID: <7v8vqku6le.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACsJy8ABBB69V3pFjGohJwAQbZ_MwGqv=p27tUHF8HAGRMLpQw@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Tue, 23 Aug 2011 08:11:29 +0700")
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
> Set *status here too? I assume we need valid *status whenever NULL is returned.
You are absolutely correct.
But I ended up deciding not to add "gently" variant for now, as nobody
needs it, and if we were to have "gently", we should also rethink the
earlier checks in the function if they should give diagnosis. Please check
what is queued near the tip of tonight's 'pu'.
Thanks.
next prev parent reply other threads:[~2011-08-23 3:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 11:58 [PATCH 1/2] clone: allow to clone from .git file Nguyễn Thái Ngọc Duy
2011-08-21 11:58 ` [PATCH 2/2] Do not accept NUL in the path in " Nguyễn Thái Ngọc Duy
2011-08-21 18:54 ` [PATCH 1/2] clone: allow to clone from " Junio C Hamano
2011-08-22 3:08 ` Nguyen Thai Ngoc Duy
2011-08-22 19:02 ` Junio C Hamano
2011-08-22 21:01 ` Re* " Junio C Hamano
2011-08-23 1:11 ` Nguyen Thai Ngoc Duy
2011-08-23 3:53 ` Junio C Hamano [this message]
2011-08-23 4:11 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vqku6le.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).