From: Junio C Hamano <gitster@pobox.com>
To: Dmitry Ivankov <divanorama@gmail.com>
Cc: git@vger.kernel.org, SASAKI Suguru <sss.sonik@gmail.com>
Subject: Re: [PATCH 3/5] fast-import: check committer name more strictly
Date: Tue, 02 Aug 2011 10:01:44 -0700 [thread overview]
Message-ID: <7v8vrbg32f.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1311831844-13123-4-git-send-email-divanorama@gmail.com
Dmitry Ivankov <divanorama@gmail.com> writes:
> Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
> ---
Please describe how you check this field "more strictly" in the body of
the log message, iow, against what rule you are validating, perhaps
something like:
The identifier must be either "<address>" or "Name <address>" where
neither address nor Name can contain '<' nor '>'; otherwise the input
stream is rejected.
As fast-import is used to _create_ new objects, its input is a simple text
file that can be fixed-up as needed, it is a good idea to validate the
input more strictly and rejecting bad ones.
next prev parent reply other threads:[~2011-08-02 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 5:43 [PATCH 0/5] fixes for committer/author parsing/check Dmitry Ivankov
2011-07-28 5:44 ` [PATCH 1/5] fast-import: add input format tests Dmitry Ivankov
2011-07-28 5:44 ` [PATCH 2/5] fast-import: don't fail on omitted committer name Dmitry Ivankov
2011-08-02 16:53 ` Junio C Hamano
2011-08-02 17:07 ` Dmitry Ivankov
2011-07-28 5:44 ` [PATCH 3/5] fast-import: check committer name more strictly Dmitry Ivankov
2011-08-02 17:01 ` Junio C Hamano [this message]
2011-07-28 5:44 ` [PATCH 4/5] fsck: add a few committer name tests Dmitry Ivankov
2011-07-28 5:44 ` [PATCH 5/5] fsck: improve committer/author check Dmitry Ivankov
2011-08-02 17:00 ` Junio C Hamano
2011-08-02 19:50 ` Dmitry Ivankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vrbg32f.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=sss.sonik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).