git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: prohaska@zib.de, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: t0050-filesystem.sh unicode tests borked on dash shell
Date: Tue, 21 Dec 2010 12:43:16 -0800	[thread overview]
Message-ID: <7v8vzi97rv.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4D1105B5.5070703@ramsay1.demon.co.uk> (Ramsay Jones's message of "Tue\, 21 Dec 2010 19\:53\:25 +0000")

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

>     $ ls trash\ directory.t0050-filesystem/unicode/
>     \x61\xcc\x88

The built-in printf in dash seems to lack understanding of '\xXX'.
It is tempting to patch it by using /usr/bin/printf but it is unclear how
portable it would be.

 t/t0050-filesystem.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh
index 41df6bc..8ad102b 100755
--- a/t/t0050-filesystem.sh
+++ b/t/t0050-filesystem.sh
@@ -4,8 +4,8 @@ test_description='Various filesystem issues'
 
 . ./test-lib.sh
 
-auml=`printf '\xc3\xa4'`
-aumlcdiar=`printf '\x61\xcc\x88'`
+auml=$(/usr/bin/printf '\xc3\xa4')
+aumlcdiar=$(/usr/bin/printf '\x61\xcc\x88')
 
 case_insensitive=
 unibad=

      parent reply	other threads:[~2010-12-21 20:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21 19:53 t0050-filesystem.sh unicode tests borked on dash shell Ramsay Jones
2010-12-21 20:27 ` [PATCH] t0050: fix printf format strings for portability Jonathan Nieder
2010-12-21 21:26   ` Junio C Hamano
2010-12-28 18:05   ` Ramsay Jones
2010-12-21 20:29 ` t0050-filesystem.sh unicode tests borked on dash shell Thomas Rast
2010-12-21 20:43 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8vzi97rv.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=prohaska@zib.de \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).