git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ben Walton <bwalton@artsci.utoronto.ca>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add a git-completion rpm subpackage to the spec
Date: Sat, 20 Mar 2010 13:12:34 -0700	[thread overview]
Message-ID: <7v8w9mda6l.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1269109086-8887-1-git-send-email-bwalton@artsci.utoronto.ca> (Ben Walton's message of "Sat\, 20 Mar 2010 14\:18\:06 -0400")

Ben Walton <bwalton@artsci.utoronto.ca> writes:

> Make the rpm spec file create a git-completion subpackage that
> contains the bash completion support from the contrib/ directory.
>
> Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
> ---
>
> This is the alternate method for shipping the bash completion support.
> I think I personally prefer this method, but I'd be happy to see
> either solution ship as part of the .spec file so that I don't need to
> continue handling it separately.

As long as %{_sysconfdir}/bash_completion.d/ is the appropriate place for
*all* RPM based distros, which I don't knonw, the patch looks sensible.
May I ask for what distribution you are "handling it"?  The last thing I
want to do is to get in the way of distro packagers.

I looked for "gitcompletion" or "git-completion" in rpmfind.net, but
didn't find anything, which may actually be a good sign that whatever we
do here won't stomp on whatever distro package maintainers would do.

  reply	other threads:[~2010-03-20 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-20  0:32 [PATCH/RFC v2] RPM spec: optionally include bash completion support Ian Ward Comfort
2010-03-20 18:18 ` [PATCH] Add a git-completion rpm subpackage to the spec Ben Walton
2010-03-20 20:12   ` Junio C Hamano [this message]
2010-03-20 21:01     ` Ian Ward Comfort
2010-03-20 21:14     ` Ben Walton
2010-03-21  1:20       ` Junio C Hamano
2010-03-21 15:51       ` Todd Zullinger
2010-03-21 20:06         ` Ben Walton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8w9mda6l.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bwalton@artsci.utoronto.ca \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).