From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Die if there are parsing errors in config file
Date: Sun, 14 Feb 2010 13:17:13 -0800 [thread overview]
Message-ID: <7v8wava55y.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100207093744.29846.6468.stgit@localhost.localdomain> (Jakub Narebski's message of "Sun\, 07 Feb 2010 10\:40\:16 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 1f6978a..a5bc359 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -556,6 +556,8 @@ if (-e $GITWEB_CONFIG) {
> our $GITWEB_CONFIG_SYSTEM = $ENV{'GITWEB_CONFIG_SYSTEM'} || "++GITWEB_CONFIG_SYSTEM++";
> do $GITWEB_CONFIG_SYSTEM if -e $GITWEB_CONFIG_SYSTEM;
> }
> +# die if there are errors parsing config file
> +die $@ if $@;
I cannot figure out $@ from which command this if statement modifier is
checking when none of GITWEB_CONFIG or GITWEB_CONFIG_SYSTEM candidates is
present. Neither of the "do" executes in such a case. Do you end up
checking the result from the very first eval that checks if Time::HiRes
can be "require"d successfully?
next prev parent reply other threads:[~2010-02-14 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 9:40 [PATCH] gitweb: Die if there are parsing errors in config file Jakub Narebski
2010-02-07 10:53 ` J.H.
2010-02-08 8:48 ` Jakub Narebski
2010-02-13 2:46 ` Jakub Narebski
2010-02-14 21:17 ` Junio C Hamano [this message]
2010-02-14 21:46 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wava55y.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).