From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] submodule.c: Squelch a "use before assignment" warning Date: Fri, 20 Nov 2009 00:05:18 -0800 Message-ID: <7v8we17ha9.fsf@alter.siamese.dyndns.org> References: <1258680785-42235-1-git-send-email-davvid@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: gitster@pobox.com, git@vger.kernel.org To: David Aguilar X-From: git-owner@vger.kernel.org Fri Nov 20 09:05:33 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1NBOUm-0006Kb-Ju for gcvg-git-2@lo.gmane.org; Fri, 20 Nov 2009 09:05:32 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbZKTIFV (ORCPT ); Fri, 20 Nov 2009 03:05:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751231AbZKTIFV (ORCPT ); Fri, 20 Nov 2009 03:05:21 -0500 Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:65216 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373AbZKTIFU (ORCPT ); Fri, 20 Nov 2009 03:05:20 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 2CBE79F15B; Fri, 20 Nov 2009 03:05:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=to:cc:subject :references:from:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=HgtXlN9GOPHPyIL787kwv6jkPjI=; b=Z5m0CK r6se65whCLXKuY+DMcyTqxV13Z2O23OkvnDQVCQsejxI/2YOCFfSfjA++yF9uZTj C1xdVlcr/4ONYwoI9kZSROmn40E+zJA46KBrCOXlid0IxT3vkYcY/bhkugMqgcbd m4f2DWK86H+PP3zH3TFYFkFUaNoRPEsxaks5w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=to:cc:subject :references:from:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=QdFT4HTQNoudNEdbRP8qJNpzeRRub3jO B0fhsvJ6qCjnfL2seSoVmJzxSznMQrtQzn6p3A9HRQ0n8W+x9eLJlJnxzEPo3DyN Q0zcDgI769BY909JYRgwJtZYrLsujfs/cHLbM8VHvAxQEOl6gDbJG7jwaxDnsO7V 3E/qhCG3QPs= Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 09FE89F15A; Fri, 20 Nov 2009 03:05:25 -0500 (EST) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 9E2689F159; Fri, 20 Nov 2009 03:05:20 -0500 (EST) In-Reply-To: <1258680785-42235-1-git-send-email-davvid@gmail.com> (David Aguilar's message of "Thu\, 19 Nov 2009 17\:33\:05 -0800") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-Pobox-Relay-ID: 751DC294-D5AB-11DE-A267-EF34BBB5EC2E-77302942!a-pb-sasl-sd.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: David Aguilar writes: > i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493) compiler > (and probably others) mistakenly thinks variable 'right' is used > before assigned. Work it around by giving it a fake initialization. We see the same "fake initialization" of 'left' on the same line. By initializing it to NULL, you are hinting that initializing 'right' to NULL actually means something. > diff --git a/submodule.c b/submodule.c > index 461faf0..0145a62 100644 > --- a/submodule.c > +++ b/submodule.c > @@ -38,7 +38,7 @@ void show_submodule_summary(FILE *f, const char *path, > const char *del, const char *add, const char *reset) > { > struct rev_info rev; > - struct commit *commit, *left = left, *right; > + struct commit *commit, *left = left, *right = NULL;