From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Stephan Beyer <s-beyer@gmx.net>,
Daniel Barkalow <barkalow@iabervon.org>,
Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH v2 5/9] revert: libify pick
Date: Fri, 21 Aug 2009 00:50:14 -0700 [thread overview]
Message-ID: <7v8whdip1l.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20090821055001.3726.15854.chriscool@tuxfamily.org
Christian Couder <chriscool@tuxfamily.org> writes:
> From: Stephan Beyer <s-beyer@gmx.net>
>
> This commit is made of code from the sequencer GSoC project:
>
> git://repo.or.cz/git/sbeyer.git
>
> (commit 5a78908b70ceb5a4ea9fd4b82f07ceba1f019079)
>
> The goal of this commit is to abstract out pick functionnality
> into a new pick() function made of code from "builtin-revert.c".
>
> The new pick() function is in a new "pick.c" file with an
> associated "pick.h".
Is it pick() or pick_commit()?
By the way, this comment applies to other messages in the series, but do
these original commits by Stephan lack any meaningful messages? I would
actually have expected to see a commit log message that looks more like:
From: Stephan Beyer <...>
Meaningful log message Stephan describes what this commit does in
sufficient detail, perhaps with clarification and rewording by
Christian.
Second and subsequent paragraph to explain it as necessary.
[cc: this is based on 5a78908b70ceb5a4ea9fd4b82f07ceba1f019079
from Stephan's git://repo.or.cz/git/sbeyer.git]
Signed-off-by: ...
The point is that the "origin info" would be a side-note, not the first
and the most important thing in the message.
next prev parent reply other threads:[~2009-08-21 7:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 5:49 [PATCH v2 0/9] more changes to port rebase -i to C using sequencer code Christian Couder
2009-08-21 5:49 ` [PATCH v2 1/9] sequencer: add "do_fast_forward()" to perform a fast forward Christian Couder
2009-08-21 5:49 ` [PATCH v2 2/9] sequencer: add "--fast-forward" option to "git sequencer--helper" Christian Couder
2009-08-21 5:49 ` [PATCH v2 3/9] sequencer: let "git sequencer--helper" callers set "allow_dirty" Christian Couder
2009-08-21 5:49 ` [PATCH v2 4/9] rebase -i: use "git sequencer--helper --fast-forward" Christian Couder
2009-08-21 5:49 ` [PATCH v2 5/9] revert: libify pick Christian Couder
2009-08-21 7:50 ` Junio C Hamano [this message]
2009-08-22 4:35 ` Christian Couder
2009-08-21 5:49 ` [PATCH v2 6/9] pick: libify "pick_help_msg()" Christian Couder
2009-08-21 5:49 ` [PATCH v2 7/9] sequencer: add "do_commit()" and related functions Christian Couder
2009-08-21 5:49 ` [PATCH v2 8/9] sequencer: add "--cherry-pick" option to "git sequencer--helper" Christian Couder
2009-08-21 5:50 ` [PATCH v2 9/9] rebase -i: use "git sequencer--helper --cherry-pick" Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8whdip1l.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).