git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Avoid unnecessary 'lstat()' calls in 'get_stat_data()'
Date: Sat, 09 May 2009 21:20:07 -0700	[thread overview]
Message-ID: <7v8wl5613c.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LFD.2.01.0905091501460.3586@localhost.localdomain

Linus Torvalds <torvalds@linux-foundation.org> writes:

> From: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Sat, 9 May 2009 14:57:30 -0700
>
> When we ask get_stat_data() to get the mode and size of an index entry,
> ...
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
> I sent this as part of the "make 'git checkout' preload the index" patch, 
> but since the preloading was of somewhat dubious value, and this part of 
> it is not, I'll just send this one-liner as an "obvious performance fix".

Oops.

I have been processing the patches in my "after 1.6.3" mailbox from the rc
freeze period and have already queued this one, but the re-integration of
four branches is taking a bit longer than usual.  It takes too much time
to run tests (and as a part of my build procedure I do docs, too) for all
integration branches, and until they all pass tests on Debian5 (primary
development box) and Fedora9 (at k.org) I do not push the result out, so
it is a bit painful for me to replace a patch once a day's testing cycle
begins.

I was about ready to push the whole thing out, but with this much improved
commit log message, it is _very tempting_ to rewind what I queued and redo
today's cycle.

I'll see how many other such (re)-sends I've got; most likely I'll redo
today's cycle after replacing what I earlier have queued with this and
your 'checkout' one, and also a patch from Dave Olszewski I want to
replace with the 'real' one.

Thanks.

  parent reply	other threads:[~2009-05-10  4:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09 22:09 [PATCH] Avoid unnecessary 'lstat()' calls in 'get_stat_data()' Linus Torvalds
2009-05-09 22:41 ` [PATCH] Teach 'git checkout' to preload the index contents Linus Torvalds
2009-05-10  4:20 ` Junio C Hamano [this message]
2009-05-10 16:50   ` [PATCH] Avoid unnecessary 'lstat()' calls in 'get_stat_data()' Linus Torvalds
2009-05-10 17:45     ` Johannes Schindelin
2009-05-10 18:40     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8wl5613c.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).