git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v3 01/10] config: Codestyle cleanups.
Date: Wed, 18 Feb 2009 11:02:23 -0800	[thread overview]
Message-ID: <7v8wo3y3eo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 94a0d4530902180118j4746a690q7a42ea087e23488@mail.gmail.com

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Hmm, right. I was thinking on Junio and Johanness that already know
> the context, so they don't need an introduction, but I forgot about
> other people that might be interested in giving this a review.

Also please don't assume anything about what other people may remember
from your earlier series, after you received "this round is not ready to
be applied because of this and that" comments.  As far as the reviewer is
concerned, that's the end of the story about the entire series, until you
send a revised one.  The reviewers are not promising to remember the fine
details of the code and to help you improve the series, thinking about the
series all the time until its next round materializes by reviewing the
first round, and it is unrealistic to expect them to.  There are a lot
more patches and patch writers than there are people who review them.

The reason you are encouraged to say want was changed since the previous
series when you are sending v(n+1) patch in each patch after three-dash
lines is exactly because by default we expect reviewers remember nothing
about the previous round and jogging their memory in such a way would help
reviewing the new round.

      reply	other threads:[~2009-02-18 19:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 13:52 [PATCH v3 01/10] config: Codestyle cleanups Felipe Contreras
2009-02-17 13:52 ` [PATCH v3 02/10] config: Cleanup editor action Felipe Contreras
2009-02-17 13:52   ` [PATCH v3 03/10] config: Make git_config() more flexible Felipe Contreras
2009-02-17 13:52     ` [PATCH v3 04/10] config: Trivial rename in preparation for parseopt Felipe Contreras
2009-02-17 13:52       ` [PATCH v3 05/10] config: Reorganize get_color* Felipe Contreras
2009-02-17 13:52         ` [PATCH v3 06/10] config: Use parseopt Felipe Contreras
2009-02-17 13:52           ` [PATCH v3 07/10] config: Disallow --getcolor* and other actions Felipe Contreras
2009-02-17 13:52             ` [PATCH v3 08/10] config: Disallow multiple config file locations Felipe Contreras
2009-02-17 13:52               ` [PATCH v3 09/10] config: Disallow multiple variable types Felipe Contreras
2009-02-17 13:52                 ` [PATCH v3 10/10] config: Don't allow extra arguments for -e or -l Felipe Contreras
2009-02-18 21:13     ` [PATCH v3 03/10] config: Make git_config() more flexible Junio C Hamano
2009-02-18 21:30       ` Felipe Contreras
2009-02-18 22:01         ` Junio C Hamano
2009-02-17 16:33 ` [PATCH v3 01/10] config: Codestyle cleanups Sverre Rabbelier
2009-02-18  9:18   ` Felipe Contreras
2009-02-18 19:02     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8wo3y3eo.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).