From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Tay Ray Chuan <rctay89@gmail.com>
Subject: [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI
Date: Mon, 02 Feb 2009 22:45:56 -0800 [thread overview]
Message-ID: <7v8woodnmj.fsf@gitster.siamese.dyndns.org> (raw)
Otherwise -Wunused-function (which is implied by -Wall) triggers.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
I think this patch is probably a bit on the wrong side of the borderline,
in that it *happens to be* that get_remote_object_url() is used by nobody
in non-multi codepath right now, but it is entirely possible that future
code clean-up can benefit from its use. But without this patch,, the file
does not compile for me (I compile everything with "-Werror -Wall").
http-push.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/http-push.c b/http-push.c
index ba5cc32..203c075 100644
--- a/http-push.c
+++ b/http-push.c
@@ -218,13 +218,6 @@ static void append_remote_object_url(struct strbuf *buf, const char *url,
strbuf_addf(buf, "%s", hex+2);
}
-static char *get_remote_object_url(const char *url, const char *hex, int only_two_digit_prefix)
-{
- struct strbuf buf = STRBUF_INIT;
- append_remote_object_url(&buf, url, hex, only_two_digit_prefix);
- return strbuf_detach(&buf, NULL);
-}
-
static void finish_request(struct transfer_request *request);
static void release_request(struct transfer_request *request);
@@ -237,6 +230,14 @@ static void process_response(void *callback_data)
}
#ifdef USE_CURL_MULTI
+
+static char *get_remote_object_url(const char *url, const char *hex, int only_two_digit_prefix)
+{
+ struct strbuf buf = STRBUF_INIT;
+ append_remote_object_url(&buf, url, hex, only_two_digit_prefix);
+ return strbuf_detach(&buf, NULL);
+}
+
static size_t fwrite_sha1_file(void *ptr, size_t eltsize, size_t nmemb,
void *data)
{
--
1.6.1.2.343.g53117
next reply other threads:[~2009-02-03 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 6:45 Junio C Hamano [this message]
2009-02-03 6:54 ` [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI Mike Hommey
2009-02-03 10:40 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8woodnmj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).