From: Junio C Hamano <gitster@pobox.com>
To: Benjamin Kramer <benny.kra@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Makefile: Use libc strlcpy on OSX >= 10.2
Date: Sat, 24 Jan 2009 11:42:10 -0800 [thread overview]
Message-ID: <7v8wp0o5il.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7f978c810901241101h227c5437p88ca7c9cc54abc9a@mail.gmail.com> (Benjamin Kramer's message of "Sat, 24 Jan 2009 20:01:04 +0100")
Benjamin Kramer <benny.kra@googlemail.com> writes:
> OSX supports strlcpy(3) since 10.2 so we don't need
> to use our own. This revised also patch checks the darwin
> version. 10.0 is darwin v1.3; 10.1 is darwin v1.4.
What does the output from "uname -r" and "uname -s" look like on your box
(and older OSX boxes)?
> @@ -643,7 +643,9 @@ ifeq ($(uname_S),Darwin)
> ifneq ($(shell expr "$(uname_R)" : '9\.'),2)
> OLD_ICONV = UnfortunatelyYes
> endif
This existing one says "If 'uname -r' output does not begin with two
characters '9.' (nine and dot), then set OLD_ICONV".
> - NO_STRLCPY = YesPlease
> + ifeq ($(shell expr "$(uname_R)" : '1\.'),2)
And this new one says "If 'uname -r' output begins with two characters
'1.' (one and dot), then set NO_STRLCPY".
> + NO_STRLCPY = YesPlease
> + endif
I am guessing that 'uname -r' says 9.X in "Darwin 9.X" (which is OSX
10.5), and existing conditional says that versions before 9.X needs
OLD_ICONV but later ones do not need it.
Does 1.X stand for OSX 10.2? A quick googling finds a handful pages that
say that OSX 10.2 = Darwin 6.x and OSX 10.3 = Darwin 7.x, and I am not
sure where you are getting that "begins with one-and-dot" from....
> NO_MEMMEM = YesPlease
> THREADED_DELTA_SEARCH = YesPlease
> endif
> --
> 1.6.1.285.g3454
next prev parent reply other threads:[~2009-01-24 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 19:01 [PATCH v2] Makefile: Use libc strlcpy on OSX >= 10.2 Benjamin Kramer
2009-01-24 19:42 ` Junio C Hamano [this message]
2009-01-24 20:23 ` Benjamin Kramer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wp0o5il.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=benny.kra@googlemail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).