git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: jidanni@jidanni.org
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] Documentation/SubmittingPatches: emacs whitespace tip
Date: Tue, 13 Jan 2009 00:28:39 -0800	[thread overview]
Message-ID: <7v8wpfd2yw.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87k58zopg5.fsf@jidanni.org> (jidanni@jidanni.org's message of "Tue, 13 Jan 2009 11:27:38 +0800")

jidanni@jidanni.org writes:

> Signed-off-by: jidanni <jidanni@jidanni.org>
> ---
>  Documentation/SubmittingPatches |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index ba07c8c..7b64343 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -442,6 +442,8 @@ whitespaces (fatal in patches).  Running 'C-u g' to display the
>  message in raw form before using '|' to run the pipe can work
>  this problem around.
>  
> +Inside gnus or not, a (setq-default show-trailing-whitespace t) in
> +one's ~/.emacs file will reduce whitespace embarrassment incidents.

What bothered me a lot more is that this part (and only this part) talks
about patch acceptance tip, not patch submission tip.  The Gnus/Emacs
section needs a total rewrite, I think.

Having a separate patch acceptance tip is fine, but I do not think it
belongs to SubmittingPatches document, and the current text certainly does
not mesh well with its neighbours.

      reply	other threads:[~2009-01-13  8:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13  3:27 [PATCH/RFC] Documentation/SubmittingPatches: emacs whitespace tip jidanni
2009-01-13  8:28 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8wpfd2yw.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).