git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH/RFC] Documentation/SubmittingPatches: emacs whitespace tip
@ 2009-01-13  3:27 jidanni
  2009-01-13  8:28 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: jidanni @ 2009-01-13  3:27 UTC (permalink / raw)
  To: git

Signed-off-by: jidanni <jidanni@jidanni.org>
---
 Documentation/SubmittingPatches |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index ba07c8c..7b64343 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -442,6 +442,8 @@ whitespaces (fatal in patches).  Running 'C-u g' to display the
 message in raw form before using '|' to run the pipe can work
 this problem around.
 
+Inside gnus or not, a (setq-default show-trailing-whitespace t) in
+one's ~/.emacs file will reduce whitespace embarrassment incidents.
 
 KMail
 -----
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH/RFC] Documentation/SubmittingPatches: emacs whitespace tip
  2009-01-13  3:27 [PATCH/RFC] Documentation/SubmittingPatches: emacs whitespace tip jidanni
@ 2009-01-13  8:28 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2009-01-13  8:28 UTC (permalink / raw)
  To: jidanni; +Cc: git

jidanni@jidanni.org writes:

> Signed-off-by: jidanni <jidanni@jidanni.org>
> ---
>  Documentation/SubmittingPatches |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index ba07c8c..7b64343 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -442,6 +442,8 @@ whitespaces (fatal in patches).  Running 'C-u g' to display the
>  message in raw form before using '|' to run the pipe can work
>  this problem around.
>  
> +Inside gnus or not, a (setq-default show-trailing-whitespace t) in
> +one's ~/.emacs file will reduce whitespace embarrassment incidents.

What bothered me a lot more is that this part (and only this part) talks
about patch acceptance tip, not patch submission tip.  The Gnus/Emacs
section needs a total rewrite, I think.

Having a separate patch acceptance tip is fine, but I do not think it
belongs to SubmittingPatches document, and the current text certainly does
not mesh well with its neighbours.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-13  8:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13  3:27 [PATCH/RFC] Documentation/SubmittingPatches: emacs whitespace tip jidanni
2009-01-13  8:28 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).