From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 2/3] git-submodule: use get_remote in resolve_relative_url Date: Sun, 24 Aug 2008 12:18:27 -0700 Message-ID: <7v8wummdbw.fsf@gitster.siamese.dyndns.org> References: <1219598500-8334-1-git-send-email-davvid@gmail.com> <341166c1e31ba26c4e8e48cd7cf9ce12a9f745b9.1219598198.git.davvid@gmail.com> <7v4p5ansxx.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mlevedahl@gmail.com, git@vger.kernel.org To: David Aguilar X-From: git-owner@vger.kernel.org Sun Aug 24 21:19:44 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KXL7n-0000TC-Hx for gcvg-git-2@gmane.org; Sun, 24 Aug 2008 21:19:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753019AbYHXTSi (ORCPT ); Sun, 24 Aug 2008 15:18:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752806AbYHXTSi (ORCPT ); Sun, 24 Aug 2008 15:18:38 -0400 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:35592 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbYHXTSh (ORCPT ); Sun, 24 Aug 2008 15:18:37 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id 8EE1C66723; Sun, 24 Aug 2008 15:18:36 -0400 (EDT) Received: from pobox.com (ip68-225-240-211.oc.oc.cox.net [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTPSA id ECE2B66722; Sun, 24 Aug 2008 15:18:31 -0400 (EDT) In-Reply-To: <7v4p5ansxx.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 24 Aug 2008 11:55:54 -0700") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 73520A3C-7211-11DD-8F6E-3113EBD4C077-77302942!a-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano writes: > David Aguilar writes: > >> This change removes replaces the remote finding logic in >> resolve_relative_url with the new get_remote function. >> >> Signed-off-by: David Aguilar > > I think these first two patches should be squashed into one, with a title > "git-submodule: refactor logic to find the remote from the current branch". > > If you agree, I'll do that myself -- no need to resend; please just say > the word. Actually, I took Mark's patch; you can do [3/3] with get_default_remote, too, right?