From: Junio C Hamano <gitster@pobox.com>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: David Aguilar <davvid@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] git-submodule: replace duplicated code with a module_list function
Date: Fri, 22 Aug 2008 17:08:42 -0700 [thread overview]
Message-ID: <7v8wuo619x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <48AF533E.9020102@gmail.com> (Mark Levedahl's message of "Fri, 22 Aug 2008 20:01:02 -0400")
Mark Levedahl <mlevedahl@gmail.com> writes:
> Actually, this was by design, not mistake, though we did not discuss
> this at all. I'm not sure what the semantics would / should be: first
> of all, some part of "$@" is the command to be executed in each
> submodule, and as written "$@" in its entirety is what is used. Also,
> as written and documented, foreach operates in each checked out
> submodule, not a subset. I guess the basic questions are:
> a) What specific option or options to git ls-files makes sense here?
> b) How do we distinguish the ls-files options from the command to be
> executed?
Ah, I was blind. For (a) I do not see any need for "option" but
pathspecs; and (b) I agree is a real problem. We of course could do
something like:
$ git submodule foreach -c 'your command here' your pathspec here
next prev parent reply other threads:[~2008-08-23 0:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 7:30 [PATCH 1/2] git-submodule: replace duplicated code with a module_list function David Aguilar
2008-08-22 7:30 ` [PATCH 2/2] git-submodule: add "sync" command David Aguilar
2008-08-22 23:13 ` Junio C Hamano
2008-08-22 22:53 ` [PATCH 1/2] git-submodule: replace duplicated code with a module_list function Junio C Hamano
2008-08-23 0:01 ` Mark Levedahl
2008-08-23 0:08 ` Junio C Hamano [this message]
2008-08-23 0:36 ` Mark Levedahl
2008-08-23 1:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wuo619x.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).