From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section
Date: Tue, 05 Aug 2008 16:46:12 -0700 [thread overview]
Message-ID: <7v8wvbuit7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <osgPH47FO7h-zLUMqwCv-i9BWln2-_AK5T6TI-5mLGFjwAhJ4Bg_lw@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Tue, 05 Aug 2008 18:23:08 -0500")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Use double quotes to protect against paths which may contain spaces.
> ...
> + echo ' mkdir -p "$(instdir_SQ)"' >> $@
Is this sufficient? We seem to apply double-sq when writing shell
scriptlet in GIT-BUILD-OPTIONS from the main Makefile, and I suspect you
would need to do something similar.
next prev parent reply other threads:[~2008-08-05 23:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mLu74vNKfH1vFZlC7N_lRX3WekWReoVjWY42voUDUBUnAGVpDNYWndWqlaHoqVAkxOaCdYV6uDk@cipher.nrlssc.navy.mil>
2008-08-05 23:23 ` [PATCH] perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section Brandon Casey
2008-08-05 23:46 ` Junio C Hamano [this message]
2008-08-06 14:25 ` Brandon Casey
2008-08-06 15:33 ` Junio C Hamano
2008-08-06 19:31 ` Brandon Casey
2008-08-06 20:15 ` Junio C Hamano
2008-08-06 21:38 ` [PATCH] perl/Makefile: handle paths with spaces by adding additional quoting Brandon Casey
2008-08-06 22:16 ` [PATCH] perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section Brandon Casey
2008-08-07 0:23 ` Brandon Casey
2008-08-06 21:48 ` [PATCH] perl/Makefile: make NO_PERL_MAKEMAKER section more robust Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wvbuit7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).