From: Junio C Hamano <gitster@pobox.com>
To: Jon Loeliger <jdl@freescale.com>
Cc: Pieter de Bie <pdebie@ai.rug.nl>, Git Mailinglist <git@vger.kernel.org>
Subject: Re: [PATCH] Documentation: Simplify git-rev-parse's example
Date: Thu, 19 Jun 2008 12:33:43 -0700 [thread overview]
Message-ID: <7v8wx1te20.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <485AAF82.3030209@freescale.com> (Jon Loeliger's message of "Thu, 19 Jun 2008 14:12:02 -0500")
Jon Loeliger <jdl@freescale.com> writes:
> Pieter de Bie wrote:
>> This example was overly complex and therefore confusing.
>> The commits have been renamed to start the oldest commit with "A"
>> and working up from there. Also, this removes some commits so the graph
>> is simpler. Finally the graph has been reversed in direction to make it
>> more like gitk.
>>
>> Signed-off-by: Pieter de Bie <pdebie@ai.rug.nl>
>> ---
>>
>> This was created after some discussion in #git about how this was confusing.
>> The consesus was that this example is better.
>
> How is this a vast improvement?
>
> I could see that inverting it top-to-bottom would
> be more consistent with gitk or show-branch output.
> Your example doesn't have a 3-parent commit, though,
> and it isn't _that_ much simpler otherwise...
>
> So this is really better _how_?
>
> Oh, right, of course. It removes my name. Got it. :-)
I agree that the patch should have just flipped the tree upside down
without changing the shape of the history the section talks about.
Yet another improvement would have been turning it sideways, not upside
down, because that is how we typically write history in our documentation
(time flows from left to right -- see e.g. git-rebase.txt).
I happen to think the last point you raise is an improvement. It will
quickly become unreadble after a while if we credit individual authors for
every paragraph in-text, and it always bothered me to see somebody's name
(don't get me wrong -- this is not because it is your name nor because it
is not my name, but because it _is_ a name), there but I wasn't bold
enough to remove it without discussion.
next prev parent reply other threads:[~2008-06-19 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 11:12 [PATCH] Documentation: Simplify git-rev-parse's example Pieter de Bie
2008-06-19 19:12 ` Jon Loeliger
2008-06-19 19:33 ` Junio C Hamano [this message]
2008-06-19 23:02 ` Pieter de Bie
2008-06-19 23:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wx1te20.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jdl@freescale.com \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).