From: Junio C Hamano <junio@pobox.com>
To: "Santi Béjar" <sbejar@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv4 4/4] user.warnautomatic: add config to control if the committer ident is shown
Date: Wed, 07 May 2008 09:12:58 -0700 [thread overview]
Message-ID: <7v8wymdred.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1209917092-12146-5-git-send-email-sbejar@gmail.com
Santi Béjar <sbejar@gmail.com> writes:
> Signed-off-by: Santi Béjar <sbejar@gmail.com>
By setting this new variable the user can squelch undesired noise the
previous change introduces, but the user can just set user.name and
user.email to desired values to squelch it anyway.
So either this new variable is superfluous, or the previous change is too
susceptible to produce false positives that need squelching with such a
variable, or both. In any case, not a very good sign.
next prev parent reply other threads:[~2008-05-07 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 16:04 [PATCHv4 0/4] Show author and/or committer in some cases Santi Béjar
2008-05-04 16:04 ` [PATCHv4 1/4] Preparation to call determine_author_info from prepare_to_commit Santi Béjar
2008-05-04 16:12 ` Santi Béjar
2008-05-04 16:04 ` [PATCHv4 2/4] commit: Show author if different from committer Santi Béjar
2008-05-06 23:34 ` Junio C Hamano
2008-05-04 16:04 ` [PATCHv4 3/4] commit: Show committer if automatic Santi Béjar
2008-05-04 16:04 ` [PATCHv4 4/4] user.warnautomatic: add config to control if the committer ident is shown Santi Béjar
2008-05-07 16:12 ` Junio C Hamano [this message]
2008-05-07 16:32 ` Santi Béjar
2008-05-04 16:25 ` [PATCHv4 0/4] Show author and/or committer in some cases Santi Béjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wymdred.fsf@gitster.siamese.dyndns.org \
--to=junio@pobox.com \
--cc=git@vger.kernel.org \
--cc=sbejar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).