Re: [PATCH 3/4] Documentation/hooks: add pre-auto-gc hook

Re: [PATCH 3/4] Documentation/hooks: add pre-auto-gc hook

[Junio C Hamano]

Miklos Vajna <vmiklos@frugalware.org> writes:

> +The default 'pre-auto-gc' hook, when enabled, defers auto repacking when
> +you are on battery.

I'd prefer not to have the Linux specific one in templates/hooks--*; it
would be a good addition to contrib/hooks/ though, if you use on_ac_power
as suggested.

In any case, we ship all hooks in templates _disabled_, and they should be
called "example hook", not "default hook".

Re: [PATCH] git gc --auto: defer on battery

[Linus Torvalds]

On Mon, 31 Mar 2008, Bj?rn Steinbrink wrote:
> 
> The /proc stuff is already deprecated IIRC, the new file to check on
> Linux is /sys/class/power_supply/AC/online.

I would *seriously* suggest making this soem kind of generic callback and 
not Linux-specific. 

How about making it more akin to a pre-auto-gc "hook" - run a script 
instead of hardcoding something like this!

		Linus

[PATCH 3/4] Documentation/hooks: add pre-auto-gc hook

[Miklos Vajna]

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 Documentation/hooks.txt |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/Documentation/hooks.txt b/Documentation/hooks.txt
index 76b8d77..04ec352 100644
--- a/Documentation/hooks.txt
+++ b/Documentation/hooks.txt
@@ -276,3 +276,13 @@ probably enable this hook.
 Both standard output and standard error output are forwarded to
 `git-send-pack` on the other end, so you can simply `echo` messages
 for the user.
+
+pre-auto-gc
+-----------
+
+This hook is invoked by `git-gc --auto`, and can be bypassed with
+`\--no-verify` option.  It takes no parameter, and exiting with non-zero
+status from this script causes the `git-gc --auto` to abort.
+
+The default 'pre-auto-gc' hook, when enabled, defers auto repacking when
+you are on battery.
-- 
1.5.5.rc2.4.g283c6