From: Junio C Hamano <gitster@pobox.com>
To: Iustin Pop <iusty@k1024.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix git pull handling of the quiet option
Date: Sat, 08 Mar 2008 20:04:26 -0800 [thread overview]
Message-ID: <7v8x0ssfud.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1205020356-6682-3-git-send-email-iusty@k1024.org> (Iustin Pop's message of "Sun, 9 Mar 2008 00:52:36 +0100")
Iustin Pop <iusty@k1024.org> writes:
> Although git pull has a documented quiet option,...
I think that is a documentation bug. pull accepts all options for fetch
for the sole purpose of passing them intact to underlying fetch, and some
options to fetch does not even make much sense in the context of pull.
Also options to pull needs to come first; the options pull does not know
about is a signal for pull that the rest is for consumption of underlying
fetch.
If you want to teach --quiet to pull, however, your patch is the right
approach. pull would eat --quiet and make a note for itself, and passes
that to underlying fetch (and perhaps merge).
You also need to sign-off your patch and add tests to make sure that other
people will not break your enhancement in the future.
next prev parent reply other threads:[~2008-03-09 4:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 23:52 Improve git pull --quiet behaviour Iustin Pop
2008-03-08 23:52 ` [PATCH 1/2] Add a quiet option to git merge Iustin Pop
2008-03-09 12:18 ` [PATCH] " Iustin Pop
2008-03-08 23:52 ` [PATCH 2/2] Fix git pull handling of the quiet option Iustin Pop
2008-03-09 4:04 ` Junio C Hamano [this message]
2008-03-09 10:31 ` Iustin Pop
2008-03-09 22:31 ` [PATCH] " Iustin Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8x0ssfud.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=iusty@k1024.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).