git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Robert Schiele <rschiele@gmail.com>
Subject: Re: [PATCH] autoconf: Add test for sys/select.h header file
Date: Fri, 25 Jan 2008 22:25:33 -0800	[thread overview]
Message-ID: <7v8x2d3xya.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1201259981-7115-1-git-send-email-jnareb@gmail.com> (Jakub Narebski's message of "Fri, 25 Jan 2008 12:19:41 +0100")

Jakub Narebski <jnareb@gmail.com> writes:

> Some systems like HP-UX don't have sys/select.h; the select stuff
> is already present in some other headef file (e.g. sys/time.h for
> HP-UX).
>
> Companion to
>   "some systems don't have (and need) sys/select.h"
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> It could be alternately just squashed together with
> "some systems don't have (and need) sys/select.h" by Robert Schiele.
>
> Robert, could you please check this patch on HP-UX? It does work
> correctly on Linux (which has sys/select.h).

The issue is not really about "do we have <sys/select.h>?" but
is about "do we need to include <sys/select.h> in order to
obtain declaration of select(2)?" so this is covering only a
half of the issue.  But I guess we will find out if the system
does not offer select(2) whether <sys/select.h> is included or
not, so this is not too bad.

Will apply.  I do not think it would have problems but even if
it does it is small and easy to revert before the final.

Thanks.

  parent reply	other threads:[~2008-01-26  6:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 18:34 [PATCH] some systems don't have (and need) sys/select.h Robert Schiele
2008-01-24 21:15 ` Johannes Schindelin
2008-01-24 21:17 ` Junio C Hamano
2008-01-24 21:58   ` Robert Schiele
2008-01-25 11:19 ` [PATCH] autoconf: Add test for sys/select.h header file Jakub Narebski
2008-01-25 12:30   ` Johannes Schindelin
2008-01-25 12:53     ` Robert Schiele
2008-01-26  6:25   ` Junio C Hamano [this message]
2008-01-26  9:42     ` Robert Schiele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8x2d3xya.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=rschiele@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).