From: Junio C Hamano <gitster@pobox.com>
To: "H.Merijn Brand" <h.m.brand@xs4all.nl>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] HP-UX does not have select.h
Date: Mon, 17 Dec 2007 13:00:22 -0800 [thread overview]
Message-ID: <7v8x3t6nq1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071217192306.5da48540@pc09.procura.nl> (H. Merijn Brand's message of "Mon, 17 Dec 2007 19:23:06 +0100")
"H.Merijn Brand" <h.m.brand@xs4all.nl> writes:
> HP-UX does not have select.h, but it offers all select () functionality.
> The defines are in <sys/types.h> and <X11/fd.h>
Will apply the patch as-is for now, only because I do not want major
surgery during rc period, but I think is can be improved.
POSIX.1-2001 expects <sys/select.h> declares select(2). With earlier
standards, including <sys/time.h>, <sys/types.h> and <unistd.h> would
have given it.
HP-UX cannot be the only pre-POSIX system; "#ifndef _HPUX_SOURCE" feels
very wrong.
Besides, isn't _HPUX_SOURCE a feature-test macro? Feature test macros
are for the application to define, and for the implementation (iow, the
header files) to find out what set of names the application wants to
see. You are making the application examine the symbol to see what
implementation it is on, which feels backwards to me.
next prev parent reply other threads:[~2007-12-17 21:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 18:23 [PATCH] HP-UX does not have select.h H.Merijn Brand
2007-12-17 21:00 ` Junio C Hamano [this message]
2007-12-17 22:22 ` H.Merijn Brand
2007-12-18 5:29 ` Junio C Hamano
2007-12-18 7:11 ` H.Merijn Brand
2007-12-18 8:16 ` Johannes Sixt
2007-12-18 12:38 ` Johannes Schindelin
2007-12-18 12:45 ` Johannes Sixt
2007-12-18 13:53 ` Johannes Schindelin
2007-12-18 14:22 ` Johannes Sixt
2007-12-18 9:30 ` Andreas Ericsson
2007-12-18 9:47 ` Junio C Hamano
2007-12-18 10:49 ` H.Merijn Brand
2007-12-19 19:57 ` Junio C Hamano
2007-12-19 20:12 ` H.Merijn Brand
2007-12-19 21:31 ` Junio C Hamano
2007-12-20 7:18 ` H.Merijn Brand
2007-12-20 7:52 ` Junio C Hamano
2007-12-23 8:37 ` Jan Hudec
2007-12-23 8:59 ` H.Merijn Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8x3t6nq1.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=h.m.brand@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).