From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 01/10] Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts.
Date: Sun, 04 Nov 2007 14:58:13 -0800 [thread overview]
Message-ID: <7v8x5dsjne.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1194172262-1563-2-git-send-email-madcoder@debian.org> (Pierre Habouzit's message of "Sun, 4 Nov 2007 11:30:53 +0100")
Two comments.
* I have updated 1/10 with typo and indentation fixes.
* I see you changed 2/10 to use OPTIONS_KEEPDASHDASH instead of
PARSEOPT_OPTS, but the scripts that do not want the --keep
behaviour do not set OPTIONS_KEEPDASHDASH to empty, so I do
not see how this updatet would make _any_ difference. The
user can still screw up by having OPTIONS_KEEPDASHDASH in
their environments by mistake, curiosity or just plain
stupidity.
next prev parent reply other threads:[~2007-11-04 22:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 10:30 ph/parseopt-sh reloaded Pierre Habouzit
2007-11-04 10:30 ` [PATCH 01/10] Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts Pierre Habouzit
2007-11-04 10:30 ` [PATCH 02/10] Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseopt Pierre Habouzit
2007-11-04 10:30 ` [PATCH 03/10] Migrate git-clean.sh to use " Pierre Habouzit
2007-11-04 10:30 ` [PATCH 04/10] Migrate git-clone " Pierre Habouzit
2007-11-04 10:30 ` [PATCH 05/10] Migrate git-am.sh " Pierre Habouzit
2007-11-04 10:30 ` [PATCH 06/10] Migrate git-merge.sh " Pierre Habouzit
2007-11-04 10:30 ` [PATCH 07/10] Migrate git-instaweb.sh " Pierre Habouzit
2007-11-04 10:31 ` [PATCH 08/10] Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdash Pierre Habouzit
2007-11-04 10:31 ` [PATCH 09/10] Migrate git-quiltimport.sh to use git-rev-parse --parseopt Pierre Habouzit
2007-11-04 10:31 ` [PATCH 10/10] Migrate git-repack.sh " Pierre Habouzit
2007-11-04 14:49 ` [PATCH 04/10] Migrate git-clone " Pierre Habouzit
2007-11-06 19:04 ` Nicolas Pitre
2007-11-06 19:32 ` Junio C Hamano
2007-11-06 19:44 ` Nicolas Pitre
2007-11-06 19:39 ` Junio C Hamano
2007-11-04 11:29 ` [PATCH 01/10] Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts Ralf Wildenhues
2007-11-04 11:31 ` Ralf Wildenhues
2007-11-04 22:58 ` Junio C Hamano [this message]
2007-11-04 23:14 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8x5dsjne.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).