From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 01/10] Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts.
Date: Sun, 04 Nov 2007 14:58:13 -0800
Message-ID: <7v8x5dsjne.fsf@gitster.siamese.dyndns.org>
References: <1194172262-1563-1-git-send-email-madcoder@debian.org>
	<1194172262-1563-2-git-send-email-madcoder@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org
To: Pierre Habouzit <madcoder@debian.org>
X-From: git-owner@vger.kernel.org Sun Nov 04 23:58:40 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IooQP-0003os-UU
	for gcvg-git-2@gmane.org; Sun, 04 Nov 2007 23:58:38 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753711AbXKDW6V (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sun, 4 Nov 2007 17:58:21 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753679AbXKDW6V
	(ORCPT <rfc822;git-outgoing>); Sun, 4 Nov 2007 17:58:21 -0500
Received: from sceptre.pobox.com ([207.106.133.20]:54827 "EHLO
	sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754617AbXKDW6U (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 4 Nov 2007 17:58:20 -0500
Received: from sceptre (localhost.localdomain [127.0.0.1])
	by sceptre.pobox.com (Postfix) with ESMTP id D43662F9;
	Sun,  4 Nov 2007 17:58:40 -0500 (EST)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 7DB99923C8;
	Sun,  4 Nov 2007 17:58:38 -0500 (EST)
In-Reply-To: <1194172262-1563-2-git-send-email-madcoder@debian.org> (Pierre
	Habouzit's message of "Sun, 4 Nov 2007 11:30:53 +0100")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/63452>

Two comments.

 * I have updated 1/10 with typo and indentation fixes.

 * I see you changed 2/10 to use OPTIONS_KEEPDASHDASH instead of
   PARSEOPT_OPTS, but the scripts that do not want the --keep
   behaviour do not set OPTIONS_KEEPDASHDASH to empty, so I do
   not see how this updatet would make _any_ difference.  The
   user can still screw up by having OPTIONS_KEEPDASHDASH in
   their environments by mistake, curiosity or just plain
   stupidity.