From: Junio C Hamano <gitster@pobox.com>
To: Simon Sasburg <simon.sasburg@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Make git-mailinfo strip whitespace from the start of the mail file.
Date: Fri, 02 Nov 2007 01:53:24 -0700 [thread overview]
Message-ID: <7v8x5h58qj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1193951139-2312-1-git-send-email-Simon.Sasburg@gmail.com> (Simon Sasburg's message of "Thu, 1 Nov 2007 22:05:39 +0100")
Simon Sasburg <simon.sasburg@gmail.com> writes:
> @@ -935,6 +936,11 @@ static int mailinfo(FILE *in, FILE *out, int ks, const char *encoding,
> p_hdr_data = xcalloc(MAX_HDR_PARSED, sizeof(char *));
> s_hdr_data = xcalloc(MAX_HDR_PARSED, sizeof(char *));
>
> + do {
> + peek = fgetc(in);
> + } while (peek == ' ' || peek == '\r' || peek == '\n');
> + ungetc(peek, in);
> +
I wonder why this is not using isspace(peek).
next prev parent reply other threads:[~2007-11-02 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 21:05 [PATCH] Make git-mailinfo strip whitespace from the start of the mail file Simon Sasburg
2007-11-01 21:33 ` Junio C Hamano
2007-11-01 21:41 ` Simon Sasburg
2007-11-01 22:26 ` Junio C Hamano
2007-11-01 22:57 ` [PATCH] Make git-mailsplit strip whitespace from the start of the mailbox file Simon Sasburg
2007-11-02 8:53 ` Junio C Hamano [this message]
2007-11-04 13:32 ` Simon Sasburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8x5h58qj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=simon.sasburg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).