From: Junio C Hamano <gitster@pobox.com>
To: Carlos Rica <jasampler@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] git-tag: Fix -l option to use better shell style globs.
Date: Fri, 31 Aug 2007 23:16:21 -0700 [thread overview]
Message-ID: <7v8x7qvrka.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <46D8F431.70801@gmail.com> (Carlos Rica's message of "Sat, 01 Sep 2007 07:10:09 +0200")
Carlos Rica <jasampler@gmail.com> writes:
> if (pattern == NULL)
> - pattern = "";
> + pattern = "*";
>
> - /* prepend/append * to the shell pattern: */
> - newpattern = xmalloc(strlen(pattern) + 3);
> - sprintf(newpattern, "*%s*", pattern);
> -
> - filter.pattern = newpattern;
> + filter.pattern = pattern;
> filter.lines = lines;
>
> for_each_tag_ref(show_reference, (void *) &filter);
I think it is conceptually simpler on the show_reference side to
allow (filter.pattern == NULL) and say:
if (!filter->pattern || !fnmatch(filter->pattern, refname, 0)) {
... show that ref ...
}
It is not such a big deal now you do not do newpattern
allocation anymore, so I'll apply the patch as is.
next prev parent reply other threads:[~2007-09-01 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 5:10 [PATCH] git-tag: Fix -l option to use better shell style globs Carlos Rica
2007-09-01 5:31 ` Shawn O. Pearce
2007-09-01 5:39 ` Junio C Hamano
2007-09-01 6:16 ` Junio C Hamano [this message]
2007-09-01 14:33 ` Carlos Rica
2007-09-01 14:46 ` Carlos Rica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8x7qvrka.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).