From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: log -g --reverse horribly insane
Date: Sun, 19 Aug 2007 02:09:52 -0700 [thread overview]
Message-ID: <7v8x87dh5r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20070819085624.GU27913@spearce.org> (Shawn O. Pearce's message of "Sun, 19 Aug 2007 04:56:24 -0400")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> OK, I'm just too tired to find this on my own right now. I'll try
> again later after I get some sleep, but maybe someone with a
> different sleeping pattern than me will find and fix this before
> I arise...
>
> git log -g --reverse --pretty=oneline
I would have to say that "-g" support was hacked into the normal
revision traversal machinery in such a way to minimize the
amount of changes, without refactoring the two completely
different traversal machineries separate to make the resulting
code maintainable. Ideal refactoring would require quite a lot
of changes, unfortunately. I would say it probably would make
sense to make the two options incompatible for now.
prev parent reply other threads:[~2007-08-19 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-19 8:56 log -g --reverse horribly insane Shawn O. Pearce
2007-08-19 9:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8x87dh5r.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).