Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: "Santi Béjar" <sbejar@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCHv2] t/t5515-fetch-merge-logic.sh: Added tests for the merge login in git-fetch
Date: Sun, 04 Mar 2007 15:30:28 -0800	[thread overview]
Message-ID: <7v8xec4mej.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <87ps7oslwk.fsf@gmail.com> (Santi Béjar's message of "Sun, 04 Mar 2007 23:07:23 +0100")

Santi Béjar <sbejar@gmail.com> writes:

> Signed-off-by: Santi Béjar <sbejar@gmail.com>
> ---
>  Hi *,
>
>    it is a much reduced version (63 instead of 400 tests) but contains
>  also tests for the fetched tags (missing anything else?).
>  I think it is suitable to be included.

Thanks.

One thing I found lacking from the last round was that the test
stripped the origin information later used by git-fmt-merge-msg
(which made the test not very helpful when I tried to use it
while working on the partial rewrite of git-fetch you see in the
'next' branch).  I haven't checked your patch this round yet,
but it would be nice to check for that to catch regressions.

  reply	other threads:[~2007-03-04 23:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-04 22:07 [PATCHv2] t/t5515-fetch-merge-logic.sh: Added tests for the merge login in git-fetch Santi Béjar
2007-03-04 23:30 ` Junio C Hamano [this message]
2007-03-05  7:34   ` Santi Béjar
2007-03-05  8:09 ` Santi Béjar
2007-03-05  8:23   ` Junio C Hamano
2007-03-05  8:28     ` Junio C Hamano
2007-03-05  8:28     ` Joshua N Pritikin
2007-03-05  8:36       ` Santi Béjar
2007-03-05  8:40         ` Junio C Hamano
2007-03-05  8:37       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8xec4mej.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=sbejar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox