git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: "Alex Riesen" <raa.lkml@gmail.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Linus Torvalds" <torvalds@osdl.org>,
	"Junio C Hamano" <junkio@cox.net>,
	git@vger.kernel.org
Subject: Re: [PATCH] Speedup recursive by flushing index only once for all entries
Date: Thu, 11 Jan 2007 12:37:36 -0800	[thread overview]
Message-ID: <7v8xg947vz.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <81b0412b0701110411s7ccb45c1t9ececa9301760bae@mail.gmail.com> (Alex Riesen's message of "Thu, 11 Jan 2007 13:11:28 +0100")

"Alex Riesen" <raa.lkml@gmail.com> writes:

> Well, tried it now. Strangely enough - there is almost no speedup with
> Junio's patch on top of mine.

Mine is primarily meant to be a conceptual clean-up.  While it
does save unnecessary write-tree at the end, and it also saves
unnecessary write-cache/read-cache for the recursive part when
you have more than one merge base, I would not be surprised if
the effect of tons of unnecessary write-index, once per path
involved in the merge, which was what your patch removed, would
drawf anything else.

Since single merge base cases dominate in practice, you might
see improvements from the avoidance of the final write-tree but
probably would not see much benefit of write-cache/read-cache
avoidance unless your merge has many merge bases.

  reply	other threads:[~2007-01-11 20:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-04 10:47 [PATCH] Speedup recursive by flushing index only once for all entries Alex Riesen
2007-01-04 12:33 ` Johannes Schindelin
2007-01-04 12:47   ` Alex Riesen
2007-01-04 20:22     ` Junio C Hamano
2007-01-05 11:22       ` Alex Riesen
2007-01-07 16:31         ` Alex Riesen
2007-01-10 18:06           ` Junio C Hamano
2007-01-10 19:28           ` Junio C Hamano
2007-01-10 22:11             ` Junio C Hamano
2007-01-10 23:07             ` Alex Riesen
2007-01-10 23:23               ` Linus Torvalds
2007-01-11  8:14                 ` Johannes Schindelin
2007-01-11  9:03                   ` Alex Riesen
2007-01-11 12:11                     ` Alex Riesen
2007-01-11 20:37                       ` Junio C Hamano [this message]
2007-01-11  9:02                 ` Alex Riesen
2007-01-11 16:38                   ` Linus Torvalds
2007-01-11 17:43                     ` Alex Riesen
2007-01-11 18:02                       ` Linus Torvalds
2007-01-11 21:48                         ` Alex Riesen
2007-01-11 20:23                     ` Junio C Hamano
2007-01-11 22:10                       ` Alex Riesen
2007-01-11 22:28                         ` Linus Torvalds
2007-01-11 23:53                           ` Junio C Hamano
2007-01-12  0:18                           ` Alex Riesen
2007-01-11  0:34               ` Junio C Hamano
2007-01-11  8:15             ` Johannes Schindelin
2007-01-12 15:48             ` Sergey Vlasov
2007-01-12 17:38               ` Alex Riesen
2007-01-12 20:37                 ` Sergey Vlasov
2007-01-12 18:23               ` Junio C Hamano
2007-01-12 20:09                 ` [PATCH] merge-recursive: do not report the resulting tree object name Junio C Hamano
2007-01-12 23:36                   ` Johannes Schindelin
2007-01-13  0:32                     ` Junio C Hamano
2007-01-13  0:57                       ` Jakub Narebski
2007-01-13 11:01                         ` Johannes Schindelin
2007-01-13  5:14                       ` Shawn O. Pearce
2007-01-13  7:03                         ` Junio C Hamano
2007-01-12 20:30                 ` [PATCH] Speedup recursive by flushing index only once for all entries Alex Riesen
2007-01-12 21:07                 ` Sergey Vlasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8xg947vz.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).