From: Junio C Hamano <junkio@cox.net>
To: Jim Meyering <jim@meyering.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure
Date: Thu, 28 Dec 2006 14:14:51 -0800 [thread overview]
Message-ID: <7v8xgrvfac.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <87tzzg6oyp.fsf@rho.meyering.net> (Jim Meyering's message of "Thu, 28 Dec 2006 16:05:02 +0100")
Jim Meyering <jim@meyering.net> writes:
> Otherwise, sending the diagnostic to stdout would provoke a protocol failure.
Very true; thanks for the patch.
However, I suspect that we'd want to prevent this by redirecting
on the caller side, so that the hook writers do not have to
worry about the issue. I haven't looked at the code that runs
the hook for some time but we should be able to do that...
prev parent reply other threads:[~2006-12-28 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 15:05 [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure Jim Meyering
2006-12-28 22:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8xgrvfac.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).