From: Junio C Hamano <junkio@cox.net>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: git@vger.kernel.org, Martin Waitz <tali@admingilde.org>,
Matthias Lederhofer <matled@gmx.net>
Subject: Re: [PATCH] gitweb.cgi: Customization
Date: Tue, 01 Aug 2006 16:54:05 -0700 [thread overview]
Message-ID: <7v8xm8xbaa.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 20060801225352.26998.qmail@web31801.mail.mud.yahoo.com
Luben Tuikov <ltuikov@yahoo.com> writes:
> As does "gitweb.css". Similarly, "gitweb.css"'s contents
> used to live in "gitweb.cgi" itself.
Not convincing argument. gitweb.css, and git-logo.png patch I
think I will take, are meant to be fed to the http clients.
They do not compare with the customization.pm which is not.
In any case, I think tweaking gitweb.cgi from Makefile like
Martin Waitz did is as easy and clean for people who want to
customize; it should just be the matter of defining the
necessary params in config.mak.
I do not think there is much difference between any of the
customization proposed so far (yours, Martin's and the one from
Matthias Lederhofer) from functionality and ease-of-use point of
view. They all try to make customization can be done in one
place, and the difference is mostly of taste, so I'd just pick
one from Martin.
next prev parent reply other threads:[~2006-08-01 23:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 21:19 [PATCH] gitweb.cgi: Customization Luben Tuikov
2006-08-01 22:15 ` Junio C Hamano
2006-08-01 22:53 ` Luben Tuikov
2006-08-01 23:54 ` Junio C Hamano [this message]
2006-08-02 2:01 ` Luben Tuikov
2006-08-02 2:13 ` Martin Langhoff
2006-08-02 7:45 ` Junio C Hamano
2006-08-02 7:59 ` Martin Langhoff
2006-08-02 15:53 ` Matthias Lederhofer
2006-08-03 6:58 ` Martin Waitz
2006-08-03 16:24 ` Jeff King
2006-08-02 7:09 ` Matthias Lederhofer
2006-08-02 8:54 ` Matthias Lederhofer
2006-08-02 9:31 ` Martin Langhoff
2006-08-02 12:55 ` Matthias Lederhofer
2006-08-02 16:23 ` Jon Loeliger
2006-08-02 16:53 ` Jeff King
2006-08-02 17:13 ` Matthias Lederhofer
2006-08-02 17:34 ` Jakub Narebski
2006-08-02 17:43 ` Junio C Hamano
2006-08-02 20:30 ` Luben Tuikov
2006-08-02 19:40 ` Matthias Lederhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8xm8xbaa.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=matled@gmx.net \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).