From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] Allow an alias to start with "-p"
Date: Tue, 25 Jul 2006 13:34:29 -0700 [thread overview]
Message-ID: <7v8xmhe84q.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0607250813450.29667@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Tue, 25 Jul 2006 08:18:46 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> Patch is below (wow, that +++ is kind of ugly!).
>
> Same here.
Same here ;-).
> Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
>
>> @@ -289,8 +289,8 @@ int main(int argc, const char **argv, ch
>> if (!strncmp(cmd, "git-", 4)) {
>> cmd += 4;
>> argv[0] = cmd;
>> - handle_alias(&argc, &argv);
>> handle_internal_command(argc, argv, envp);
>> + handle_alias(&argc, &argv);
>> die("cannot handle %s internally", cmd);
>> }
>
> Alternatively, you can just delete it. IIRC we decided that aliases with
> "git-" commands do not make sense.
I think that is reasonable and simpler.
prev parent reply other threads:[~2006-07-25 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 23:25 [PATCH] Allow an alias to start with "-p" Johannes Schindelin
2006-07-24 6:32 ` Junio C Hamano
2006-07-24 12:10 ` Johannes Schindelin
2006-07-25 0:36 ` Junio C Hamano
2006-07-25 6:27 ` Johannes Schindelin
2006-07-25 5:03 ` Jeff King
2006-07-25 6:18 ` Johannes Schindelin
2006-07-25 20:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8xmhe84q.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox