git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Sean <seanlkml@sympatico.ca>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add "--branches", "--tags" and "--remotes" options to git-rev-parse.
Date: Sun, 14 May 2006 16:24:57 -0700	[thread overview]
Message-ID: <7v8xp4196e.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <BAYC1-PASMTP043948149786B7EE06DED3AEA20@CEZ.ICE> (seanlkml@sympatico.ca's message of "Sat, 13 May 2006 21:43:00 -0400")

Sean <seanlkml@sympatico.ca> writes:

> On a related note, would it be okay to change "git tag -l" to
> produce a list of tags without the "tags/" prefix in front of
> every tag as it does now?  Wanted to use the new "git
> rev-parse --tags" instead of "find" to produce the list but am
> not sure how important backward compatibility is in that case.

I do not have problem with that, but somebody else's script
might; Cogito seems not to mind.

Something like this perhaps?

-- >8 --
diff --git a/git-tag.sh b/git-tag.sh
index dc6aa95..2286ad5 100755
--- a/git-tag.sh
+++ b/git-tag.sh
@@ -28,11 +28,10 @@ do
         cd "$GIT_DIR/refs" &&
 	case "$#" in
 	1)
-		find tags -type f -print ;;
-	*)
-		shift
-		find tags -type f -print | grep "$@" ;;
+		set x . ;;
 	esac
+	shift
+	find tags -type f -print | sed -e 's|^tags/||' | grep "$@"
 	exit $?
 	;;
     -m)

  reply	other threads:[~2006-05-14 23:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060513111332.59e4c0c9.seanlkml@sympatico.ca>
2006-05-13 15:13 ` [PATCH] Add "--branches" and "--tags" options to git-rev-parse Sean Estabrooks
2006-05-13 17:38   ` Junio C Hamano
     [not found]     ` <20060513214300.4bfb01a2.seanlkml@sympatico.ca>
2006-05-14  1:43       ` [PATCH] Add "--branches", "--tags" and "--remotes" " Sean
2006-05-14 23:24         ` Junio C Hamano [this message]
     [not found]           ` <20060514200739.11c9d3a5.seanlkml@sympatico.ca>
2006-05-15  0:07             ` Sean
2006-05-15 20:11         ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8xp4196e.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=seanlkml@sympatico.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).