From: Junio C Hamano <junkio@cox.net>
To: Andreas Ericsson <ae@op5.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-cvsimport: Add -A <author-conv-file> option
Date: Fri, 13 Jan 2006 00:45:51 -0800 [thread overview]
Message-ID: <7v8xtkbjnk.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 7vzmm0g45a.fsf@assigned-by-dhcp.cox.net
Junio C Hamano <junkio@cox.net> writes:
> Andreas Ericsson <ae@op5.se> writes:
>
>> Anyways, I can keep this separate if you don't want to accept it.
>
> Oh, I haven't formed an opinion on accept/reject yet. I was
> just trying to see if you are aware of that (especially Pasky's
> message in that thread) and thought about issues like "if in
> some repositories CVSROOT/users is in usable form then perhaps
> making sure -A file has the same format and suggest its use in
> the documentation would be nicer".
OK, after a little googling around, I have formed an opinion. I
agree to the patch in principle, but at least it would be nicer
to use "CVSROOT/users" compatible format before giving it to the
general public.
http://computing.ee.ethz.ch/sepp/cvs-1.10-to/cvsbook/main_70.html
seems to indicate that:
- colon ':' is used instead of your '='.
- RHS, if it contains a whitespace, is quoted either with
single or double quote.
It was a bit unclear to me how quote characters are to be
quoted, so the patch needs a bit of research, quoting (when
writing out new records) and unquoting (when reading) in the
script, but otherwise I think it is a welcome change.
Opinions from other heavy CVS users?
next prev parent reply other threads:[~2006-01-13 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 23:38 [PATCH] git-cvsimport: Add -A <author-conv-file> option Andreas Ericsson
2006-01-13 1:55 ` Junio C Hamano
2006-01-13 2:14 ` Andreas Ericsson
2006-01-13 4:09 ` Junio C Hamano
2006-01-13 8:45 ` Junio C Hamano [this message]
2006-01-13 3:19 ` Alexander Litvinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8xtkbjnk.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).