From: Junio C Hamano <junkio@cox.net>
To: exon@op5.se (Andreas Ericsson)
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] Library code for user-relative paths, take three.
Date: Thu, 17 Nov 2005 15:56:51 -0800 [thread overview]
Message-ID: <7v8xvmsu9o.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051117193714.2B8995BF93@nox.op5.se> (Andreas Ericsson's message of "Thu, 17 Nov 2005 20:37:14 +0100 (CET)")
exon@op5.se (Andreas Ericsson) writes:
> + if(strict && *dir != '/')
(style everywhere)
if (strict ...
> + /* This is perfectly safe, and people tend to think of the directory
> + * where they ran git-init-db as their repository, so humour them. */
> + (void)chdir(".git");
It might be safe, but I think it changes the behaviour of
upload-pack with strict case. My gut reaction is we would want
"if (!strict)" in front. Thoughts?
next prev parent reply other threads:[~2005-11-17 23:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 19:37 [PATCH 1/5] Library code for user-relative paths, take three Andreas Ericsson
2005-11-17 23:56 ` Junio C Hamano [this message]
2005-11-18 10:08 ` Andreas Ericsson
2005-11-18 10:14 ` Andreas Ericsson
2005-11-18 20:33 ` H. Peter Anvin
2005-11-18 22:49 ` Andreas Ericsson
2005-11-18 23:23 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8xvmsu9o.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=exon@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).