From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] Write a good 'git stash store' for autostash
Date: Fri, 14 Jun 2013 07:26:47 -0700 [thread overview]
Message-ID: <7va9mssr88.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1371205924-8982-1-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Fri, 14 Jun 2013 16:01:59 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> So, I've taken Junio's suggestion and designed a proper command-line
> interface for 'git stash store' in this iteration:
>
> git stash store [-m <message>] [-e <error>] <commit>
I am perplexed; that would not something I _would_ design or
suggest. The "-e <error>" looks especially odd, in that "-e"
usually refers to something the command evaluates (e.g. sed, perl),
but more importantly if the caller wants a custom error message,
normal programmers would do
command || die "my custom error message"
and if "command" wants to show its own error by default, perhaps do
command --quiet || die "my custom error message"
next prev parent reply other threads:[~2013-06-14 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 10:31 [PATCH v2 0/5] Write a good 'git stash store' for autostash Ramkumar Ramachandra
2013-06-14 10:32 ` [PATCH 1/5] stash doc: add a warning about using create Ramkumar Ramachandra
2013-06-14 12:27 ` Phil Hord
2013-06-14 15:11 ` Junio C Hamano
2013-06-14 10:32 ` [PATCH 2/5] stash doc: document short form -p in synopsis Ramkumar Ramachandra
2013-06-14 10:32 ` [PATCH 3/5] stash: simplify option parser for create Ramkumar Ramachandra
2013-06-14 10:32 ` [PATCH 4/5] stash: introduce 'git stash store' Ramkumar Ramachandra
2013-06-14 12:39 ` Phil Hord
2013-06-14 10:32 ` [PATCH 5/5] rebase: use 'git stash store' to simplify logic Ramkumar Ramachandra
2013-06-14 12:47 ` Phil Hord
2013-06-14 13:40 ` Ramkumar Ramachandra
2013-06-14 14:26 ` Junio C Hamano [this message]
2013-06-14 15:16 ` [PATCH v2 0/5] Write a good 'git stash store' for autostash Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7va9mssr88.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).