git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [BUG] Highly inconsistent diff UI
@ 2013-04-24 12:23 Ramkumar Ramachandra
  2013-04-24 16:40 ` Jonathan Nieder
  2013-04-24 16:44 ` [BUG] " Junio C Hamano
  0 siblings, 2 replies; 45+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-24 12:23 UTC (permalink / raw)
  To: Git List

Hi,

The 'git diff <commit> <commit>' form is perfectly fine: I can
understand that diff takes two commit^{tree}s to compare.
Unfortunately, it also shows off the examples 'git diff A..B' and 'git
diff A...B', where A..B and A...B do not correspond to the meaning
specified in gitrevisions.txt.  There's a note in the documentation
saying this, but I'm very unhappy.

I can understand that rev-parse parses A..B into ^A B.  'git diff
A..B' is the same as 'git diff A B', 'git diff B ^A', and 'git diff ^A
B'?  (Yeah, I saw the code and found out that it swaps the arguments
only if the second argument is UNINTERESTING)

rev-parse parses A...B into A B ^$(merge-base --all A B).  But 'git
diff A...B' means 'git diff $(git merge-base A B) B'?  And the
merge-base is picked at random (found out that from the code)?

What about other things like 'git diff ^A ^B' and 'git diff A^!'?  Why
is diff so inconsistent with everything else?  Why are A..B and A...B
almost coded in as special cases?  What should we do to improve the
situation?

Thanks for listening.

^ permalink raw reply	[flat|nested] 45+ messages in thread

end of thread, other threads:[~2013-04-29 21:13 UTC | newest]

Thread overview: 45+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-24 12:23 [BUG] Highly inconsistent diff UI Ramkumar Ramachandra
2013-04-24 16:40 ` Jonathan Nieder
2013-04-24 17:49   ` Junio C Hamano
2013-04-24 18:12     ` Ramkumar Ramachandra
2013-04-24 19:23     ` Jonathan Nieder
2013-04-24 20:02       ` Junio C Hamano
2013-04-24 20:14         ` Ramkumar Ramachandra
2013-04-24 16:44 ` [BUG] " Junio C Hamano
2013-04-24 16:51   ` Ramkumar Ramachandra
2013-04-24 18:11     ` Junio C Hamano
2013-04-24 18:48       ` Ramkumar Ramachandra
2013-04-24 19:00         ` Ramkumar Ramachandra
2013-04-24 19:24           ` Junio C Hamano
2013-04-24 19:29             ` Ramkumar Ramachandra
2013-04-24 21:27               ` Junio C Hamano
2013-04-24 22:06                 ` Ramkumar Ramachandra
2013-04-24 20:44           ` Thomas Rast
2013-04-24 20:54             ` Ramkumar Ramachandra
2013-04-24 21:02               ` Jonathan Nieder
2013-04-24 21:10                 ` Ramkumar Ramachandra
2013-04-25  7:32               ` Thomas Rast
2013-04-25  8:06                 ` Ramkumar Ramachandra
2013-04-25 16:37                 ` Junio C Hamano
2013-04-25 17:11                   ` Ramkumar Ramachandra
2013-04-25 23:21                     ` Jonathan Nieder
2013-04-25 23:39                       ` Junio C Hamano
2013-04-26 12:34               ` Duy Nguyen
2013-04-24 21:25           ` Phil Hord
2013-04-24 21:23         ` Junio C Hamano
2013-04-24 22:44           ` Ramkumar Ramachandra
2013-04-24 23:17             ` Ramkumar Ramachandra
2013-04-25  5:59               ` Junio C Hamano
2013-04-25  7:51                 ` Ramkumar Ramachandra
2013-04-25  9:30                   ` Ramkumar Ramachandra
2013-04-26 10:47                   ` Ramkumar Ramachandra
2013-04-26 11:35                     ` Ramkumar Ramachandra
2013-04-29 16:32                   ` Junio C Hamano
2013-04-29 18:21                     ` Ramkumar Ramachandra
2013-04-29 18:43                       ` Junio C Hamano
2013-04-29 19:03                         ` Ramkumar Ramachandra
2013-04-29 19:17                           ` Ramkumar Ramachandra
2013-04-29 19:56                           ` Junio C Hamano
2013-04-29 21:12                             ` Ramkumar Ramachandra
2013-04-29 18:32                     ` John Keeping
2013-04-25  4:27             ` Ramkumar Ramachandra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).