git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] t5501-*.sh: Fix url passed to clone in setup test
Date: Sun, 20 Nov 2011 19:24:49 -0800	[thread overview]
Message-ID: <7vaa7qi2da.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4EC805CE.10203@ramsay1.demon.co.uk> (Ramsay Jones's message of "Sat, 19 Nov 2011 19:38:54 +0000")

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

> In particular, the url passed to git-clone has an extra '/' given
> after the 'file://' schema prefix, thus:
>
>     git clone --reference=original "file:///$(pwd)/original one
>
> Once the prefix is removed, the remainder of the url looks something
> like "//home/ramsay/git/t/...", which is then interpreted as an
> network path. This then results in a "Permission denied" error, like
> so:
>
>     ramsay $ ls //home
>     ls: cannot access //home: No such host or network path
>     ramsay $ ls //home/ramsay
>     ls: cannot access //home/ramsay: Permission denied
>     ramsay $
>
> In order to fix the problem, we simply remove the extraneous '/'
> character from the url.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---

Thanks; obviously correct.


>  t/t5501-fetch-push-alternates.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t5501-fetch-push-alternates.sh b/t/t5501-fetch-push-alternates.sh
> index b5ced84..1bc57ac 100755
> --- a/t/t5501-fetch-push-alternates.sh
> +++ b/t/t5501-fetch-push-alternates.sh
> @@ -28,7 +28,7 @@ test_expect_success setup '
>  		done
>  	) &&
>  	(
> -		git clone --reference=original "file:///$(pwd)/original" one &&
> +		git clone --reference=original "file://$(pwd)/original" one &&
>  		cd one &&
>  		echo Z >count &&
>  		git add count &&

      reply	other threads:[~2011-11-21  3:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-19 19:38 [PATCH 1/3] t5501-*.sh: Fix url passed to clone in setup test Ramsay Jones
2011-11-21  3:24 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vaa7qi2da.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).