git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: "Ævar Arnfjörð" <avarab@gmail.com>,
	"Jonas Flodén" <jonas@floden.nu>, "Eric Herman" <eric@freesa.org>,
	"Fernando Vezzosi" <fv@repnz.net>,
	"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] Add abbreviated commit hash to rebase conflict message
Date: Sun, 06 Nov 2011 12:27:52 -0800	[thread overview]
Message-ID: <7vaa89573r.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAGdFq_j7NxojZ+82s0GJ8ZF0oyd5sH8t0kcMOTQGtKbASXqYTA@mail.gmail.com> (Sverre Rabbelier's message of "Sun, 6 Nov 2011 20:35:09 +0100")

Sverre Rabbelier <srabbelier@gmail.com> writes:

> On Sun, Nov 6, 2011 at 05:14, Junio C Hamano <gitster@pobox.com> wrote:
>> I am puzzled, but that cannot be true. The existing message uses $msgnum
>> and $FIRSTLINE but does not use $commit because it does not necessarily
>> exist.
>>
>> What a value would the variable contain when I am applying your original
>> patch message using "git am -s" (or "git am -s3")?
>
> Aaah, I understand the concern you raise now. In that case a spurious
> [] would be printed, which I agree is less than desirable. Would
> checking 'if test -n $commit' be sufficient?

In what situation does it make sense to say "It came from _this_ commit"?

I think there is a separate variable that allows any part of the script if
we are being run as a backend of rebase or not, and that is the condition
you are looking for.

  reply	other threads:[~2011-11-06 20:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-05 14:02 [PATCH] Add abbreviated commit hash to rebase conflict message Sverre Rabbelier
2011-11-06  0:31 ` Junio C Hamano
2011-11-06  0:37   ` Sverre Rabbelier
2011-11-06  4:14     ` Junio C Hamano
2011-11-06 19:35       ` Sverre Rabbelier
2011-11-06 20:27         ` Junio C Hamano [this message]
2011-11-06 20:42           ` Sverre Rabbelier
2011-11-07  0:12             ` Junio C Hamano
2011-11-09 18:25               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vaa89573r.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=eric@freesa.org \
    --cc=fv@repnz.net \
    --cc=git@vger.kernel.org \
    --cc=jonas@floden.nu \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).