* [PATCH] gitk: Show patch for initial commit
@ 2011-09-30 21:50 Marcus Karlsson
2011-10-01 9:54 ` Zbigniew Jędrzejewski-Szmek
0 siblings, 1 reply; 4+ messages in thread
From: Marcus Karlsson @ 2011-09-30 21:50 UTC (permalink / raw)
To: git; +Cc: gitster
Make gitk show the patch for the initial commit.
Signed-off-by: Marcus Karlsson <mk@acc.umu.se>
---
gitk-git/gitk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 4cde0c4..20aeae6 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {
lappend cmd HEAD
}
} else {
- set cmd [concat | git diff-tree -r $flags $ids]
+ set cmd [concat | git diff-tree -r --root $flags $ids]
}
return $cmd
}
--
1.7.7.rc3.4.g8d714
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gitk: Show patch for initial commit
2011-09-30 21:50 [PATCH] gitk: Show patch for initial commit Marcus Karlsson
@ 2011-10-01 9:54 ` Zbigniew Jędrzejewski-Szmek
2011-10-01 18:42 ` Marcus Karlsson
0 siblings, 1 reply; 4+ messages in thread
From: Zbigniew Jędrzejewski-Szmek @ 2011-10-01 9:54 UTC (permalink / raw)
To: Marcus Karlsson; +Cc: git, gitster
On 09/30/2011 11:50 PM, Marcus Karlsson wrote:
> Make gitk show the patch for the initial commit.
>
> Signed-off-by: Marcus Karlsson<mk@acc.umu.se>
> ---
> gitk-git/gitk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 4cde0c4..20aeae6 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {
> lappend cmd HEAD
> }
> } else {
> - set cmd [concat | git diff-tree -r $flags $ids]
> + set cmd [concat | git diff-tree -r --root $flags $ids]
> }
> return $cmd
> }
Cool, this works for me! But I think I would be really nice if gitk
respected the configuration value of log.showroot. This would give nice
consistency amongst the various tools.
Zbyszek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gitk: Show patch for initial commit
2011-10-01 9:54 ` Zbigniew Jędrzejewski-Szmek
@ 2011-10-01 18:42 ` Marcus Karlsson
2011-10-01 20:20 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Marcus Karlsson @ 2011-10-01 18:42 UTC (permalink / raw)
To: Zbigniew J??drzejewski-Szmek; +Cc: git, gitster
On Sat, Oct 01, 2011 at 11:54:11AM +0200, Zbigniew J??drzejewski-Szmek wrote:
> On 09/30/2011 11:50 PM, Marcus Karlsson wrote:
> >Make gitk show the patch for the initial commit.
> >
> >Signed-off-by: Marcus Karlsson<mk@acc.umu.se>
> >---
> > gitk-git/gitk | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/gitk-git/gitk b/gitk-git/gitk
> >index 4cde0c4..20aeae6 100755
> >--- a/gitk-git/gitk
> >+++ b/gitk-git/gitk
> >@@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {
> > lappend cmd HEAD
> > }
> > } else {
> >- set cmd [concat | git diff-tree -r $flags $ids]
> >+ set cmd [concat | git diff-tree -r --root $flags $ids]
> > }
> > return $cmd
> > }
> Cool, this works for me! But I think I would be really nice if gitk
> respected the configuration value of log.showroot. This would give
> nice consistency amongst the various tools.
I agree, that would be reasonable. I'll prepare a new patch with that
behavior.
Marcus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gitk: Show patch for initial commit
2011-10-01 18:42 ` Marcus Karlsson
@ 2011-10-01 20:20 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2011-10-01 20:20 UTC (permalink / raw)
To: Marcus Karlsson; +Cc: Zbigniew J??drzejewski-Szmek, git, gitster
Marcus Karlsson <mk@acc.umu.se> writes:
>> >diff --git a/gitk-git/gitk b/gitk-git/gitk
>> >index 4cde0c4..20aeae6 100755
>> >--- a/gitk-git/gitk
>> >+++ b/gitk-git/gitk
>> >@@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {
>> > lappend cmd HEAD
>> > }
>> > } else {
>> >- set cmd [concat | git diff-tree -r $flags $ids]
>> >+ set cmd [concat | git diff-tree -r --root $flags $ids]
>> > }
>> > return $cmd
>> > }
>> Cool, this works for me! But I think I would be really nice if gitk
>> respected the configuration value of log.showroot. This would give
>> nice consistency amongst the various tools.
>
> I agree, that would be reasonable. I'll prepare a new patch with that
> behavior.
That would be good, but whatever you do please keep the maintainer of
gitk, Paul Mackerras <paulus@samba.org>, in the loop.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-01 20:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-30 21:50 [PATCH] gitk: Show patch for initial commit Marcus Karlsson
2011-10-01 9:54 ` Zbigniew Jędrzejewski-Szmek
2011-10-01 18:42 ` Marcus Karlsson
2011-10-01 20:20 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).